[PATCH] Avoid signed/unsigned comparison

Mark Wielaard mark@klomp.org
Thu Apr 27 22:35:00 GMT 2017


On Thu, Apr 20, 2017 at 04:40:30PM +0200, Ulf Hermann wrote:
> Some compilers implicitly cast the result of uint_fast16_t *
> uint_fast16_t to something signed and then complain about the
> comparison to (unsigned) size_t.

Really? That is allowed? Using a signed type for uint_fast16_t?

> Casting phnum to size_t is a good idea anyway as 16bit multiplication
> can easily overflow and we are not checking for this.

OK, that seems an ok enough reason.
Applied to master.

Thanks,

Mark



More information about the Elfutils-devel mailing list