[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #16 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 13:41:14 GMT ---
(In reply to comment #15)
> Do you have an example of the multi-line macros that are giving problems?

/hal/cortexm/lm3s/var/current/include/var_io.h:
CYGHWR_HAL_LM3S_GPIO

under devs/ there are macros like

devs/i2c/cortexm/lm3s/current/include/i2c_lm3s.h:
# define CYG_LM3S_I2C_BUS(_name_, _init_fn_, _base_, _periph_, _isr_vec_,
_isr_pri_, _fdr_)       \
static lm3s_i2c_extra _name_ ## _extra = {                                     
    \

IMO, this

#define CYG_LM3S_I2C_BUS(                                       \
        _name_,                                                 \
        _init_fn_,                                              \
        _base_,                                                 \
        _periph_,                                               \
        _isr_vec_,                                              \
        _isr_pri_,                                              \
        _fdr_)                                                  \
        static lm3s_i2c_extra _name_ ## _extra = {              \

        etc.

looks better. It's good to catch such things with $PAGER, e.g.

  $ less -S super.diff
  /\\$

Christope, excuse my pedanry, please, I just thouhgt, If he will resubmit the
patch then it would be nice, if he will clean-up some issues for me :-)

Thanks!
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.