Update to CYGPKG_IO_ADC

Sergei Gavrikov sergei.gavrikov@gmail.com
Wed May 26 07:20:00 GMT 2010


On Tue, 25 May 2010, Christophe Coutand wrote:
> On Tue, 25 May 2010, Sergei Gavrikov wrote:
> Hi Sergei,
>
> Thanks for your inputs. Attached is the updated patch. Let me know if
> more changes are required.
>
> Christophe

Hi Christophe,

I retested this one. The compiler's error went away, thank you. And now
your patch looks great for me.

[snip]

> And I had a thought about some CDL wrapping the limit, e.g.
>
>     cdl_component CYGSEM_DEVS_ADC_ARM_AT91_SAMPLE_SIZE_LIMIT {
>         display       "Sample size limit"
>         flavor        bool
>         calculated    1
>         requires      {CYGNUM_IO_ADC_SAMPLE_SIZE >= 10}
>         requires      {CYGNUM_IO_ADC_SAMPLE_SIZE <= 12}
>         description   "
>             Tell user about the limitation."
>     }

[snip]

The last thing. When I typed in an example above "Tell user about..." I
thought that you put there (in description) some paraphrase from AT91
datasheet and there is almost mine in CDL :-) Well, you can sent me just
a few descriptive sentences. As you understand it will be then displayed
in `configtool` (the component's description). I will fix it.

Thanks,
Sergei



More information about the Ecos-patches mailing list