cortexm stm32 invert backup domain protect macros

Simon Kallweit simon.kallweit@intefo.ch
Wed Nov 12 07:37:00 GMT 2008


>
>> Thinking about it after having done the checkin, I'm not entirely
>> happy with the naming of CYGHWR_HAL_STM32_BD_UNPROTECT() and 
>> hal_stm32_bd_unprotect(). The un... parts could be a little confusing
>> and the sense of things seems wrong. I would be happier with
>> CYGHWR_HAL_STM32_BD_PROTECT() and hal_stm32_bd_protect() with a
>> matching inversion of the meaning of the argument. It is probably not
>> worth worrying about immediately, but is something that might need to
>> change in the future.
>>   
>
> I see your point, I'll change that tomorrow.

Here is the patch to change CYGHWR_HAL_STM32_BD_UNPROTECT() to 
CYGHWR_HAL_STM32_BD_PROTECT(). I guess this is better done early than later.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cortexm_stm32_invert_bd_protect.patch
Type: text/x-diff
Size: 4281 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20081112/ede625d0/attachment.bin>


More information about the Ecos-patches mailing list