flash_olpcx2294_v2 package
Sergei Gavrikov
sg@belvok.com
Tue Dec 2 10:57:00 GMT 2008
Sergei Gavrikov wrote:
> On Tue, Dec 02, 2008 at 08:29:43AM +0100, Andrew Lunn wrote:
> > > ..Hm, and this morning it seemed for me that the best place would be
> > > var_arch.h. lpc2xxx's var_io.h has a lot of defines and those in mainly
> > > are I/O macros. IMHO, memory access is something another, isn't it? If
> > > my morning opinion is right, a patch is provided.
> >
> > You are using these macros for memory mapped IO. So var_io.h seems
> > correct to me. However, as the find(1) showed, there is no 100%
> > correct answer.
>
> Thank you for a feedback. I fully trust your experience. As you suggest
> it placed in a right place and there are ifdef there.
I'm sorry, quick patching break things. There was 1 #ifndef without
argument :-( Fixed.
Sergei
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lpc2xxx_var.diff
Type: text/x-diff
Size: 2061 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20081202/1c5e4254/attachment.bin>
More information about the Ecos-patches
mailing list