io-pcmcia patch

[Shaun Louie]

Gary Thomas wrote:
> Shaun Louie wrote:
>   
>> Hi,
>>
>> This patch adds the cf_remove_handler() function (counterpart to 
>> cf_register_handler).  It also adds calls to cf_hwr_interrupt_enable() 
>> and cf_hwr_interrupt_disable().  Since these are new functions to be 
>> provided by the driver, some empty functions will need to be added in 
>> any existing drivers (e.g. devs/pcmcia/arm/cerf).  I can provide a patch 
>> if you like, but I won't be able to test.  I'll be providing a PCMCIA 
>> driver for the PowerPC MPC8xx shortly.
>>     
>
> This (and the MPC8xx driver) overall look OK, but we'll need
> a few things before much more can be done with them.
>
> * You need a copyright assignment (unless I missed it)
>    Please see http://ecos.sourceware.org/assign.html
>   
I sent the email request to the FSF (assign@gnu.org) today finally.  
We're working towards getting the company I work for, Microplex Systems, 
covered by the assignment...
> * The MPC8xx driver is too platform specific.  We try to
>    split drivers into architecture (or CPU family) + target.
>    In this case, I think that all of the details like where the
>    window is mapped, what I/O pins are used for VSn, etc,
>    should be in a target [include] file, not coded directly
>    within the MPC8xx driver.
>   
... in the meantime, the attached patch file should address the issues 
mentioned above.  I added a section at the top of pcmcia_mpc8xx.h that 
describes what needs to be provided by the target.

Shaun


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: devs-pcmcia-mpc8xx.patch
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20080429/645cab25/attachment.ksh>