[patch] Philips D12 USB Slave Driver

Frank Pagliughi fpagliughi@mindspring.com
Fri May 19 22:43:00 GMT 2006


Andrew Lunn wrote:

>On Tue, Apr 11, 2006 at 05:23:46PM -0400, Frank Pagliughi wrote:
>  
>
>>Andrew Lunn wrote:
>>
>>    
>>
>>>Hi Frank
>>>
>>>On Tue, Apr 11, 2006 at 09:35:28AM -0400, Frank Pagliughi wrote:
>>>
>>>
>>>      
>>>
>>>>This is a driver for the Philips PDIUSBD12 (D12) USB Slave Controller 
>>>>Chip. It was written for the D12 on a PC/104 (ISA) board. With some 
>>>>minor adjustments and testing should go with any CPU. I (tried to) 
>>>>removed all the board-specific stuff, which, unfortunately also meant 
>>>>removing DMA support.
>>>>  
>>>>
>>>>        
>>>>
>>>I just had a very quick look at the code. I does seem to have a few
>>>x386ism's in it but they are all nicely abstracted. Do you think you
>>>can split this into two packages. A generic D12 driver and an i386
>>>specific part. It would contain the functions to actually access the
>>>hardware. You could put these into an inline header file so there
>>>would be no loss of performance.
>>>
>>>
>>>      
>>>
>>Yeah, I thought of trying something like that at the last minute, 
>>especially to get the DMA code back in there. But I'm leaving town for a 
>>few weeks, so I thought I would throw it at you to get some suggestions. 
>>I can have a look when I get back. Can you point me to any example that 
>>does this sort of thing? The PC serial ports, maybe?
>>    
>>
>
>Hi Frank 
>
>Take a look at the attached code. It will need a few clean ups,
>comments, ChangeLog etc, but it should give you the idea. I had to
>guess how the DMA word work, so i might have it wrong. 
>
>  
>
>>Oops. I messed up the patch. Didn't clear out my directory very well 
>>before creating it. The "target.c" is actually an emacs backup file of 
>>the existing "usbtarget.c" that's in the USB tests directory 
>>(packages/io/usb/slave/current/tests). Note the "~" in the file name. 
>>Sorry about that. Ignore that file.
>>    
>>
>
>Yep, my silly error. I'm an emacs uses so should know better!
> 
>  
>
>>I will submit a few minor changes to that file, though, in the near 
>>future. Probably as configuration options. There are a few things 
>>hard-wired into the test program that need to be configured for the 
>>specific chip - such as the size of control endpoint zero.
>>    
>>
>
>O.K. please let me have these patches when you are ready.
> 
>  
>
>>In the patch, there is, however a valid, minor, update to the host side 
>>of the existing test program that runs on Linux, "usbhost.c"  The host 
>>didn't recognize the target when run on Fedora Core 4. The fix should 
>>allow it to run on FC4, plus whatever system it was originnaly designed for.
>>    
>>
>
>Thanks. I've already committed this change, and the same in chmod
>program.
>
>How is the copyright assignment going?
>
>        Andrew
>
>
>  
>
Andrew,

Here's the updated patch for the USB D12 driver. It is mainly the 
changes that you posted last time, having split out the i386 specifics, 
with a few very minor fixes. In addition I added back the package 
declarations for ecos.db. It should patch the latest CVS.

The copyright assignment is in the mail.

Frank


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ecos-usbs-d12.patch
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20060519/a107b708/attachment.ksh>


More information about the Ecos-patches mailing list