RedBoot: fis free: don't ignore chunk at start.

[David Vrabel]

Andrew Lunn wrote:
> Im assuming you don't have redboot at the bottom of flash,
> but fis free thinks it is in use and so will not list this section.

Yep.

> Probably a better fix would be to set CYGBLD_REDBOOT_MIN_IMAGE_SIZE to
> zero when CYGOPT_REDBOOT_FIS_REDBOOT is disabled. You could do this
> from cdl, something like
> 
> cdl_option CYGBLD_REDBOOT_MIN_IMAGE_SIZE {
>     display       "Minimum image size"
>     flavor        data
>     default_value { CYGOPT_REDBOOT_FIS_REDBOOT ? 0x20000 : 0 }
>     description "
>        This option controls the minimum length of images kept by
>        the FIS.  In particular, it should be large enough to hold
>        the RedBoot primary image itself, as well as be a natural
>        multiple of the FLASH erase block size."
> }

No, this isn't correct either.  I have a different board (an i386 board) 
that has RedBoot at the top of flash so setting this option to 0 in this 
case won't work.

Also. should this option really be:

cdl_option CYGBLD_REDBOOT_MAX_REDBOOT_IMAGE_SIZE {
      display       "Maximum size of a RedBoot image"
      flavor        data
      default_value { CYGOPT_REDBOOT_FIS_REDBOOT ? 0x20000 : 0 }
      description "
         This option controls the maximum size of the RedBoot image in
         the FIS table."
}

Since that's all it's used for.

Regardless, does find_free() really need to explicitly ignore that 
beginning chunk?  RedBoot should have a FIS entry and (if my 
understanding of find_free() is right) it will ignore it anyway.

David Vrabel
-- 
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/