new Target - phytec phycore AT91M55800A and AT91serial driver patch (3UARTS)

[Sebastian Block]

Am Sonntag, 17. Oktober 2004 17:14 schrieb Andrew Lunn:
> On Wed, Oct 13, 2004 at 11:02:47AM +0200, Sebastian Block wrote:
> > Hi,
> >
> > I've done initial work and testing on eval board from Phytec
>
> Hi Sebastian
>
> I took a first look at the HAL.
>
> ChangeLog:
>
> Your copyright messages will have to be replaced with RedHat or
> eCosCentric, depending on who you make the assignment to. This applies
> to all files you might have a copyright statement in.
>
> Please wrap the long line at around 78 charactors.
>
> hal_arm_at91_phycore.cdl:
>
> Both CYGNUM_HAL_VIRTUAL_VECTOR_DEBUG_CHANNEL and
> CYGNUM_HAL_VIRTUAL_VECTOR_CONSOLE_CHANNEL say the EBxx board has two
> serial ports. This should be changed to say the PhyCore has three.
>
> hal_platform_ints.h:
>
> Change AT91/EB55 to AT91/PhyCore in the header, twice.
>
> hal_platform_setup.h:
>
> Delete the code inside #if 0.
>
> plf_io.h: More references to EB55 to change to PhyCore
>
> phycore_misc.c:
>
> hal_at91_set_leds(). Im guessing you only have one LED? You should
> still look at the val parameter to determine if to turn that one LED
> on or off.
>
> These are all minor issuses. Once these are cleared up and the
> copyright assignemt is in place i can commit your HAL to anoncvs very
> quickly.
>
> Your phycore.db fragment contains a flash driver for the phycore, but you
> have not provided the sources for this. At least it is not in the
> .tar.gz file. If you would like this commiting as well please let me
> have a copy.
>
> Your at91_serial.diff patch seems to have been cut short....
>
> $ patch -p0 < ~/at91_serial.diff
> patching file devs/serial/arm/at91/current/src/at91_serial.c
> patching file hal/arm/at91/var/current/src/hal_diag.c
> patch unexpectedly ends in middle of line
> patch unexpectedly ends in middle of line
>
> but the resulting files look OK. Once i've committed the code please
> check this. You might also want to find out what truncated your patch.
I've done all changes you commited.

But the copyright statement I doesn't understand !!
Do I have to delete my statement or must assign it to eCoscentric !?
Perhabs now it's correct (hopefully).

Patch also fixed .. don't know what goes wrong.

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: phycore.tar.gz
Type: application/x-tgz
Size: 9468 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20041018/23da581f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial.diff
Type: text/x-diff
Size: 8852 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20041018/23da581f/attachment-0001.bin>