Patch for negotiating ACCM and accepting a NULL PAP password.

[Nick Garnett]

Parvathaneni Murali <PMurali@hypercom.com> writes:

> The attached patch file has been created from the "net" directory under ecos/packages and it has
> changes for negotiation ACCM when using PPP and also for accepting a NULL value for PAP password.
> Please let me know if these changes are acceptable.


I'm not happy about this.

I'm not sure that doing PAP with a NULL password is in the spirit of
how these protocols should be used. Either you should set refuse_pap,
or use a proper password. The original PPPD code doesn't allow a NULL
password for a reason, we should respect that.

ACCM negotiation should be an option settable in cyg_ppp_options_t. It
shouldn't be on by default. At the same time the actual map being
negotiated should be settable too. This should all follow the way that
the original PPPD code handles options.


-- 
Nick Garnett                    eCos Kernel Architect
http://www.ecoscentric.com/     The eCos and RedBoot experts