redboot peek and poke commands for prodding I/O ports

[Ian Campbell]

On Tue, 2004-11-09 at 12:07 +0100, Andrew Lunn wrote:
> On Fri, Oct 29, 2004 at 03:16:06PM +0100, Ian Campbell wrote:
> > Hi,
> > 
> > The patch adds command peek and poke to RedBoot which can be used to
> > access I/O mapped regions in the same way mfill and dump can be used on
> > memory mapped regions. By default they are only enabled on i386
> > platforms since it is the only one I know of that has a separate I/O
> > bus.
> 
> I don't like the naming of these commands. From the Jargon File:
>   
> The definition is that it access memory locations, not IO
> locations. So i would prefer different names. iopeek and iopoke might
> be possible, or "in" and "out" as you said in the cdl file.

I went with iopeek and iopoke -- in and out are a little generic (in one
sense, and i386 specific in another)...

> Please could you include this as part of the patch itself. The less
> work i have to do, the more likely a patch will get accepted quickly.

done. our local ChangeLog includes the entire history of the feature so
I have constructed a single entry against the main eCos CVS tree.

> Also the HAL_READ_ and HAL_WRITE_ macros should exist on all
> platforms, so i don't see a need to make these commands conditional on
> x86. It should not really make a difference if the IO is memory mapped
> into the normal memory address space or in a different address
> space. The commands are still valid.

The first time I submitted the patch I was asked to disable it by
default, then recently I decided that enabling by default on x86 made
sense. In any case -- I've enabled it by default now.

New patch attached.

Thanks!
Ian.

-- 
Ian Campbell, Senior Design Engineer
                                        Web: http://www.arcom.com
Arcom, Clifton Road,                    Direct: +44 (0)1223 403 465
Cambridge CB1 7EA, United Kingdom       Phone:  +44 (0)1223 411 200


_____________________________________________________________________
The message in this transmission is sent in confidence for the attention of the addressee only and should not be disclosed to any other party. Unauthorised recipients are requested to preserve this confidentiality. Please advise the sender if the addressee is not resident at the receiving end.  Email to and from Arcom is automatically monitored for operational and lawful business reasons.

This message has been virus scanned by MessageLabs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: redboot-iopeek-iopoke.diff
Type: text/x-patch
Size: 14060 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20041109/d9184c0e/attachment.bin>