[ECOS] possibly a bug in select.cxx without CYGPKG_POSIX

Andrew Lunn andrew@lunn.ch
Wed Dec 15 14:55:00 GMT 2004


On Wed, Dec 15, 2004 at 09:45:34AM -0500, Nicolas Brouard wrote:
> Hi, 
> 
> I have an error when compiling select.cxx. 
> In my configuration, CYGPKG_POSIX is not included, so "sigset_t oldmask" is 
> not defined (line 160), but it is used line 242 and 303. 

Yep, i knew about that and have a fix in my tree. I've just committed
it now. Attached is the patch.

        Andrew
-------------- next part --------------
Index: io/fileio/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/io/fileio/current/ChangeLog,v
retrieving revision 1.52
diff -u -r1.52 ChangeLog
--- io/fileio/current/ChangeLog	2 Dec 2004 12:34:30 -0000	1.52
+++ io/fileio/current/ChangeLog	15 Dec 2004 14:52:43 -0000
@@ -1,3 +1,8 @@
+2004-12-15  Andrew Lunn  <andrew.lunn@ascom.ch>
+
+	* src/select.cxx (cyg_pselect): We need the oldmask under all
+	conditions.
+
 2004-12-01  Alex Paulis and Cameron Taylor  <ctaylor@waverider.com>
 
 	* include/fileio.h: Changed si_thread to si_waitFlag
Index: io/fileio/current/src/select.cxx
===================================================================
RCS file: /cvs/ecos/ecos/packages/io/fileio/current/src/select.cxx,v
retrieving revision 1.14
diff -u -r1.14 select.cxx
--- io/fileio/current/src/select.cxx	2 Dec 2004 12:34:33 -0000	1.14
+++ io/fileio/current/src/select.cxx	15 Dec 2004 14:52:44 -0000
@@ -156,9 +156,8 @@
     cyg_tick_count ticks;
     int mode_type[] = {CYG_FREAD, CYG_FWRITE, 0};
     cyg_uint32 wake_count;
-#ifdef CYGPKG_POSIX
     sigset_t oldmask;
-#endif
+
     Cyg_FlagValue myFlag = SELECT_WAIT_FLAG_GET ();
     int    maxFdIndex = __howmany(nfd, __NFDBITS); // size of fd sets
 


More information about the Ecos-patches mailing list