[PATCH] CYGIMP_KERNEL_SCHED_SORTED_QUEUES flaws.

Sergei Organov osv@topconrd.ru
Tue Dec 14 18:21:00 GMT 2004


Sergei Organov <osv@topconrd.ru> writes:
> For reference, here is the description:
> 
>     cdl_option CYGIMP_KERNEL_SCHED_SORTED_QUEUES {
>         display       "Dequeue oldest threads first"
>         flavor        bool
>         default_value 0
>         description   "
>             With this option enabled, threads queued in a thread queue
>             will be dequeued in priority order, rather than last in,
>             first out (LIFO). Threads of equal priority are dequeued
>             oldest first. The only exception is the scheduler run 
>             queues where order is less important as each is already
>             sorted by priority. Note that this makes the thread queueing
>             less deterministic."
>     }
> 
> 
> First, it seems that "display" should say something like "Dequeue
> highest priority threads first" to be consistent with the description
> and the meaning of the option.
> 
> Second, the "... rather than last in, first out (LIFO)" seems to be
> just wrong. Shouldn't it be "... rather than first in, first out (FIFO)"
> instead?

Well, as nobody had commented, here is a patch that fixes it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ecos-sched-sorted-queues.patch
Type: text/x-patch
Size: 1245 bytes
Desc: Fix description
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20041214/5a5bc7ff/attachment.bin>


More information about the Ecos-patches mailing list