ppp chat scripts fix

Nick Garnett nickg@ecoscentric.com
Thu Apr 15 15:57:00 GMT 2004


Øyvind Harboe <oyvind.harboe@zylin.com> writes:

> A ppp chat script did not return success when it ran to completion.

Hmmm, it looks like at some point I was trying to decide whether this
function should return true/false or 0=success/!0=fail and left it
somewhere in the middle.

> 
> I also changed cyg_ppp_chat_success to be a local variable as I could
> see no reason why it should be a static variable.
>

This is probably an hangover from an expectation that some of the
called functions might need to change this. Hence the test in the loop
condition.

I've checked in a slightly munged version of your patch (attached),
and added a paragraph to the documentation.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ppp.chat
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20040415/c62084a6/attachment.ksh>
-------------- next part --------------


-- 
Nick Garnett                    eCos Kernel Architect
http://www.ecoscentric.com      The eCos and RedBoot experts


More information about the Ecos-patches mailing list