pxa2x0 platform

[Knud Woehler]

Holger Schurig wrote:

>>This is an impressive port - I've just inspected it and for the first time
>>in a long time I don't have a single comment to make! Unless anyone has
>>any other comments on it (you know who you are :-)) I'd like to check it
>>straight in.
>>
> 
> Some...
> 
> - some files have CRLF at the end, but the rest of eCos follows Unix 
> convention

OK.

> 
> - in hal/arm/xscale/mpc50/current/include/hal_platform_setup.h I see 
> init_mmu_cache_on, init_mmu_off but I have the feeling that this is 
> PXA250-specific, not mpc50-specific. The same is true for init_sdram_cnt, 
> althought this function needs board-specific values to do it's job.

You are right. The mmu setup can be moved to the pxa2x0 stuff.

> 
> 
> 
Knud


-- 
MICROPLEX Printware AG                       Tel.: +49 (0) 4451-9137-0
Panzerstrasse 5                              Fax.: +49 (0) 4451-81063
D-26316 Varel                                http://www.microplex.de