mips32 cld change

Jonathan Larmour jifl@eCosCentric.com
Fri Jan 3 14:16:00 GMT 2003


Tim Michals wrote:
> Added a choice to select little or big endian, this helps building a variant
> hal based on mips32 hal.

Before I can check in this patch, there's a few little problems. Firstly 
you didn't update the display or description from what you copied the new 
option from. Secondly, I'd slightly prefer your option values to be just 
"Big" and "Little" to avoid the odd looking (IMHO) hyphenation.

Lastly, you can shorten those lines with the compiler flags on by using 
"CYGPKG_HAL_MIPS_LSBFIRST ? " instead of the longer alternative with the 
new option.

> The default is big-endian, but it might be better to have it default to
> little for malta board build.

For continuity it's probably best to keep the default as little endian.

Lastly when you generate a patch, can you use "cvs diff -u5 -p" to 
generate it rather than a plain diff? It makes patches much more reliable. 
You can make this the default by adding the line:

diff -u5 -p

to your ~/.cvsrc file.

Also your mailer wrapped the patch at 80 columns anyway, so it was 
definitely corrupted. Try attaching it as an attachment if your mailer 
refuses to co-operate.

Jifl
-- 
eCosCentric       http://www.eCosCentric.com/       <info@eCosCentric.com>
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine



More information about the Ecos-patches mailing list