redboot decompress.c fixes - ChangeLog

[Gary Thomas]

On Fri, 2003-12-05 at 07:32, Ian Campbell wrote:
> > Applied
> 
> Cheers.
> 
> > although I'm not sure I understand your last comment about
> > the initialization.
> 
> I was referring to the code I added to _zlib_init() which sets up the
> memlist pointer. Normally this is done in gzip_init(), but that function
> didn't appear to be called when using JFFS2 in Redboot. Perhaps I was
> mistaken though.

In that case, perhaps the code should be removed from gzip_init() [note:
it's now duplicated which is bad].  If the lists truly need to be reset
every time gzip_init() is called (as it is now), then that should be
addressed.

Bottom line - initializing these structures (free memory list, etc) in
two places is poor practice and will tend toward error.

I'll take care of this.  Good of you to notice this, thanks.

-- 
Gary Thomas <gary@mlbassoc.com>
MLB Associates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diffs
Type: text/x-patch
Size: 1679 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/ecos-patches/attachments/20031205/8bc86bf7/attachment.bin>