[ECOS] Two things about cyg_types

Andrew Lunn andrew@lunn.ch
Thu Oct 26 13:49:00 GMT 2006


On Thu, Oct 26, 2006 at 02:01:59PM +0200, Stefan Sommerfeld wrote:
> Hello,
> 
> I found two strange things in cyg_types. The first one is in line 316 where 
> __GNUC_VERSION__ is defined. To define the whole gcc version it tries to 
> find out if PATCHLEVEL is defined. My gcc (3.4.6) has __GNUC_PATCHLEVEL__ 
> defined by cyg_types checks for __GNU_PATCHLEVEL__ but uses the GNUC 
> define. I think the line 316 should look more like
> #if defined(__GNUC_PATCHLEVEL__)

Yes, that looks like a typo. Please produce a patch and i will test it
with the stock arm compiler and my native compiler for synth.

> Second one is a comment which doesn't fit the define. At line 395 where 
> CYGBLD_ATTRIB_USED is defined the comment says that the define changes for 
> gcc 3.3.4 and above, but the define uses gcc 3.4.4. Something is wrong 
> here, the comment or the define.

Looking at
http://www.ohse.de/uwe/articles/gcc-attributes.html#func-unused
suggests that both are supported up to 3.4. I would suggest changing
the comment unless its actually causing you a problem with 3.4.6.
Please send us a patch.

    Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss



More information about the Ecos-discuss mailing list