[ECOS] Limitations with the SNTP client? - patch
Wed Nov 8 15:19:00 GMT 2006
On Wed, Nov 08, 2006 at 09:57:34AM -0500, Andre-John Mas wrote:
> Do I post this here? I have never posted a patch before, so I am kinda
> new to this.
The ecos-patches mailling list please.
> Removed optional KeyIdentifer and MesageDigest fields, which
> weren't being used, and caused certain servers not to respond
> when these fields were included with null values.
Please put this in the ChangeLog file in the sntp directory. Follow
the format of the other entries.
> > /* Note that the KeyIdentifier and MessageDigest fields are not
> > included since they are optional (RFC2030) and in certain cases
> > will cause some SNTP servers from responding if included with
> > null values.
> > */
> < cyg_uint32 KeyIdentifier; /* Optional */
> < cyg_uint8 MessageDigest; /* Optional */
Please use the unified format to diff, ie -u. It is easier to read.
I would also not bother with the comment. You have put the same in the
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
More information about the Ecos-discuss