[ECOS] Re: RedBoot doesn't handle telnet WILL properly.

Grant Edwards grante@visi.com
Fri Apr 7 23:25:00 GMT 2006


On Fri, Apr 07, 2006 at 04:59:24PM -0600, Gary Thomas wrote:
> On Sat, 2006-04-01 at 17:56 +0000, Grant Edwards wrote:
> > Why does RedBoot handle DO but not WILL?  It's normal for a
> > telnet client to send a bunch of WILL commands after connecting
> > to a server.
> > 
> > The current code in net_io_getc_nonblock() handles the telnet
> > DO by replying with a WONT (which is a correct). But, when it
> > receives a WILL sequence from the client, it just returns the
> > option code as a received character and doesn't reply to the
> > client.
> > 
> > This causes the first command read by the main loop to contain
> > a bunch of "garbage" characters consisting of all of the option
> > codes which the client said it "WILL" do during option
> > negotiation.
> > 
> > I've added code to net_io_getc_nonblock() in my version of
> > RedBoot to fix this problem.
> 
> Seems reasonable - applied (with a ChangeLog - next time, please
> provide one and send to ecos-patches :-)

I was planning on doing that if somebody expressed interest in
the fix.  I wasn't sure if it was something anybody else cared
about or not.

I've got a RedBoot TCP stack fix for which I need to gen a
patch too...

-- 
Grant Edwards
grante@visi.com



-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss



More information about the Ecos-discuss mailing list