[ECOS] Re: spi registers (PDC registers)

[Andrew Lunn]

On Tue, Oct 05, 2004 at 07:04:15PM +0200, Andrea Michelotti wrote:
> Hi,
> I completely agree with SPI register definition in var_io.h. And I'm happy
> for the eCos spi driver (I'll try it asap) in the repository.

OK. Please submit a patch which removes the definitions from the JTST
HAL.

> But I think there is a problem with PDC SPI/USART DMA registers
> (XX_TPR,XXTCR...).
> In fact these addresses can be different  from chip to chip (diopsis is
> different from eb55 and so on), they depend on how the PDC is compiled.
> I suggest you only to put a #ifndef on PDC DMA registers to protect them
> from multiple definition.

Please submit a patch for review.

       Thanks
          Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss