[ECOS] bug about MPC8260 FEC driver?

[Gary D. Thomas]

On Sat, 2003-03-01 at 22:54, he_hai_yang wrote:
> in file ...\ecos\packages\devs\eth\powerpc\quicc2\current\src\if_fec.c
> founction fec_eth_init():
> 
> there are code :
> if (cache_state) {
>       HAL_DCACHE_DISABLE();
>       HAL_DCACHE_INVALIDATE_ALL();
>     }
> 
> i think it should be:
> if (cache_state) {
>       HAL_DCACHE_SYNC();
>       HAL_DCACHE_DISABLE();
>     }
> 
> If we call HAL_DCACHE_DISABLE() here, some modified in the ram will lose. In our test, once system goes here, the value of net_mem (in support.c) will change to 0.
>  

What version of the code are you referring to?  I made major
changes in how the data cache is handled in this driver a 
long time ago (back in October, 2002).

Try updating to the latest CVS and see if you still have problems.

-- 
.--------------------------------------------------------.
|       Mind: Embedded Linux and eCos Development        |
|--------------------------------------------------------|
| Gary Thomas              email:  gary.thomas@mind.be   |
| Mind ( http://mind.be )  tel:    +1 (970) 229-1963     |
| gpg: http://www.chez-thomas.org/gary/gpg_key.asc       |
'--------------------------------------------------------'


-- 
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss