[ECOS] recvfrom patch

Jonathan Larmour jlarmour@redhat.com
Thu Jan 3 18:03:00 GMT 2002


Wade Jensen wrote:
> 
> Hello,
> 
> The recv function calls recvfrom with NULL parameters.  recvfrom then
> dereferences a NULL pointer.  This patch is a simple fix for this.  I have
> tested it a LOT, and it does not seem to have any bad effects.

Thanks for the patch!

Although:
+    msg.msg_namelen = fromlen ? *fromlen : (socklen_t)fromlen;

why use (socklen_t)fromlen, i.e. the address of some variable? I've checked
in just:

        msg.msg_namelen = fromlen ? *fromlen : 0;

instead if that's alright.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine



More information about the Ecos-discuss mailing list