[ECOS] problem with redboot's fis create -n option

[Gary Thomas]

On Fri, 2001-09-28 at 06:52, todd.kallam@acterna.com wrote:
> 
> 
> 
> Hi,
> 
> I have been using redboot on the assabet for a couple of months,
> and I noticed that the "fis create" command  with the -n option
> no longer works correctly.  I usually use the following commands
> to copy my jffs2 image (size = 0xb80000) to flash and then
> create the fis entry:
> 
>    redboot> load root.jffs2 -r -b 0x100000
> 
>    redboot> fis free
>               This returns 0x50140000 ... 0x51F80000
> 
>    redboot> fis unlock -f 0x50140000 -l 0x1E40000
>    redboot> fis erase -f 0x50140000 -l 0x1E40000
>    redboot> fis write -b 0x100000 -l 0xb80000 -f 0x50140000
>    redboot>  fis create "JFFS2" -n -f 0x50140000 -l 0x1E40000
> 
> The "fis create" command returns with no error messages and
> no message about programming the flash.  When I do an "fis list",
> the JFFS2 partition is not listed.
> 
> All of this used to work correctly.  I have looked at the code and
> found that if I make the following change to fis_create() in
> /packages/redboot/current/src/flash.c, the old behavior is back.
> 
>            // Change initialization of prog_ok to true:
>             bool prog_ok = true;
> 
> I am using the -n option to create the fis entry so that I can
> create a JFFS2 partition that is much larger than the JFFS2
> image that I have programmed into flash.
> 
> Is this the correct way to fix the problem?

While I will look at the problem (it seems to be a bug), why don't
you just use the '-s' option to 'fis create'?  It'll do exactly
what you are trying to do, in a single step.