[ECOS] HAL_SavedRegisters (ecos 1_3_1)

[Nick Garnett]

Jonathan Larmour <jlarmour@redhat.com> writes:

> Rafael Rodríguez Velilla wrote:

> >   I'd also want to point out that the method load_context of the class
> > Cyg_HardwareThread seems to me that does the wrong thing. It is
> > implemented like:
> > inline void Cyg_HardwareThread ::load_context ()
> > {
> >    CYG_ADDRESS dummy_stack_ptr;
> >    HAL_THREAD_SWITCH_CONTEXT(&dummy_stack, &stack_ptr);
> > }
> > 
> > I think that HAL_THREAD_LOAD_CONTEXT is the correct function to call
> > (and dummy_stack_ptr is unnecessary). load_context shouldn't, because of
> > its definition, save the old context.
> 
> Again I think you're right. Nick, do you agree?
> 

We should probably get rid of the whole function. It is no longer
necessary and its presence might lure the unwary into actually calling
it, with dire consequences.

-- 
Nick Garnett, eCos Kernel Architect
Red Hat, Cambridge, UK