[PING] [PATCH] [testsuite] fix Handle readelf following links by default(b1f26dc76158e)

lvying lvying6@huawei.com
Mon Jan 17 07:44:22 GMT 2022


A gentle reminder to please review this patch.

> The two testcases still failed when using newer readelf(binutils commit c46b706620e):
> testsuite/dwz.tests/odr-struct-multifile.sh
> testsuite/dwz.tests/cycle.sh
> 
> fix the new -Wn readelf flag test
> 
> Signed-off-by: Lv Ying <lvying6@huawei.com>
> ---
>   testsuite/dwz.tests/cycle.sh                | 2 +-
>   testsuite/dwz.tests/odr-struct-multifile.sh | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testsuite/dwz.tests/cycle.sh b/testsuite/dwz.tests/cycle.sh
> index 85aa556..17f8eb5 100644
> --- a/testsuite/dwz.tests/cycle.sh
> +++ b/testsuite/dwz.tests/cycle.sh
> @@ -1,5 +1,5 @@
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> diff --git a/testsuite/dwz.tests/odr-struct-multifile.sh b/testsuite/dwz.tests/odr-struct-multifile.sh
> index 20b682b..159cbc3 100644
> --- a/testsuite/dwz.tests/odr-struct-multifile.sh
> +++ b/testsuite/dwz.tests/odr-struct-multifile.sh
> @@ -3,7 +3,7 @@ if ! $execs/dwz-for-test --odr -v 2>/dev/null; then
>   fi
>   
>   readelf_flags=""
> -if readelf -h 2>&1 | grep -q "\-wN,"; then
> +if readelf -h 2>&1 | grep -q "\-wN"; then
>       readelf_flags=-wN
>   fi
>   
> 


-- 
Thanks!
Lv Ying


More information about the Dwz mailing list