[PATCH] Fix twice-multifile.sh

Mark Wielaard mark@klomp.org
Wed Mar 3 23:21:50 GMT 2021


Hi Tom,

On Tue, Mar 02, 2021 at 11:10:43AM +0100, Tom de Vries wrote:
> After "Clean up temporary file in hardlink mode", test-case twice-multifile.sh
> started failing.
> 
> The test-case first dwz-compresses files 1 and 2 in single-file mode.
> Then it attempts a dwz -m 3 1 2.
> 
> This results in a res.res value of 1 (processed, unchanged) for both files.
> 
> This causes the files not to be counted as a success in main, and multifile
> mode optimization is skipped.
> 
> Fix this by handling res.res == 1 in main.

OK, so now we are OK with either files that are changed and unchanged,
as long as they didn't actually fail to be processed. This looks
good. But as I said in the previous patch I would like to commit this
and the last patch together so we don't have failing testcases
inbetween.

Thanks,

Mark


More information about the Dwz mailing list