[PATCH] Remove left over "negate" adjustment in compute_abbrevs.

Mark Wielaard mark@klomp.org
Mon Feb 15 09:21:03 GMT 2021


Hi Tom,

On Mon, 2021-02-15 at 09:32 +0100, Tom de Vries wrote:
> On 2/14/21 4:34 PM, Mark Wielaard wrote:
> > Before commit 47af8da7c "Assorted DW_FORM_implicit_const fixes" there
> > was a hack to track whether decl/call_file line numbers had been
> > translated already. This worked by negating the value once it was
> 
> I'd add "translated" here, reads easier.
> 
> > and
> > not translating again when the value was negative. Then in
> > compute_abbrevs all negated values we made positive again. Most of
> 
> we -> were
> 
> > this hack was removed in the above commit. Except for making all
> > negated values positive again in compute_abbrevs. Remove it there too.
> > No decl/call_file line number tables can ever be negative.
> > 
> 
> LGTM.

Thanks. Pushed with the suggested changes to the commit message.

Cheers,

Mark


More information about the Dwz mailing list