[PATCH 1/3] find-debuginfo: Refactor output directory

[Mark Wielaard]

Hi Michal,

Apologies I forgot about this patch set.

On Wed, Oct 29, 2025 at 04:11:53PM +0100, Michal Domonkos via Debugedit wrote:
> Separate the output directory path for the artifacts (*.list) from
> $BUILDDIR so that we can make it configurable in the next commit.
> 
> No functional change.

Thanks for splitting this out, it makes the patch series as a whole
easier.

> Signed-off-by: Michal Domonkos <mdomonko@redhat.com>
> ---
>  scripts/find-debuginfo.in | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> index 40cd182..8bb688a 100755
> --- a/scripts/find-debuginfo.in
> +++ b/scripts/find-debuginfo.in
> @@ -330,21 +330,23 @@ fi
>  
>  $quiet || echo "find-debuginfo: starting" 2>&1
>  
> +OUTDIR=$BUILDDIR
> +
>  i=0
>  while ((i < nout)); do
> -  outs[$i]="$BUILDDIR/${outs[$i]}"
> +  outs[$i]="$OUTDIR/${outs[$i]}"
>    l=''
>    for f in ${lists[$i]}; do
> -    l="$l $BUILDDIR/$f"
> +    l="$l $OUTDIR/$f"
>    done
>    lists[$i]=$l
>    ((++i))
>  done

OK, -o output files fo to OUTDIR.
  
> -LISTFILE="$BUILDDIR/$out"
> -SOURCEFILE="$BUILDDIR/debugsources.list"
> -LINKSFILE="$BUILDDIR/debuglinks.list"
> -ELFBINSFILE="$BUILDDIR/elfbins.list"
> +LISTFILE="$OUTDIR/$out"
> +SOURCEFILE="$OUTDIR/debugsources.list"
> +LINKSFILE="$OUTDIR/debuglinks.list"
> +ELFBINSFILE="$OUTDIR/elfbins.list"

OK, same for other file lists.

>  > "$SOURCEFILE"
>  > "$LISTFILE"
> @@ -888,7 +890,7 @@ if [ -d "${RPM_BUILD_ROOT}/usr/lib" ] || [ -d "${RPM_BUILD_ROOT}/usr/src" ]; the
>  fi
>  
>  if [ -n "$srcout" ]; then
> -  srcout="$BUILDDIR/$srcout"
> +  srcout="$OUTDIR/$srcout"
>    > "$srcout"

And for the debugsourcefiles.list (as given by -S)

All looks good.

Thanks,

Mark