[Bug find-debuginfo/33135] find-debuginfo test regressions in 5.2

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=33135

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Michał Górny from comment #3)
> It's disabled by default.  Apparently we've tried enabling it shortly, and
> it caused quite a mayhem (https://bugs.gentoo.org/526144).  FWICS we're
> focusing on generating them at package manager level instead
> (https://bugs.gentoo.org/953869).

Aha, I think the issue is that you are trying to combine
--enable-linker-build-id with the on-disk build-id databases under
/usr/lib/.build-id and /usr/lib/debug/.build-id

While it is great to have both, it seems simpler to first enable having
build-ids in all binaries and then build the database on top of that (and if
you always use debuginfod then the on-disk database is optional anyway).

It is a great way to detect embedded binaries though.

> (In reply to Mark Wielaard from comment #2)
> > If your gcc isn't configured to produce build-ids by default (it really
> > should!) then the following forcing build-id generation in the test cases
> > might fix the tests for you:
> 
> Yeah, I can confirm that this fixes the tests.

Thanks for testing, pushed:

commit c011f478dca2c89d52958a8999b99663d14db85d (HEAD -> main)
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue Jul 8 13:05:37 2025 +0200

    find-debuginfo.at: Make sure foo, bar and baz have build-ids

    There are still distros that don't configure gcc with
    --enable-linker-build-id. So explicitly add -Wl,--build-id
    to the test binaries generated.

    https://sourceware.org/bugzilla/show_bug.cgi?id=33135

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.