[PATCH] Do not assume xxhash can always inline

Qi.Chen@windriver.com Qi.Chen@windriver.com
Mon Jan 20 07:20:20 GMT 2025


From: Chen Qi <Qi.Chen@windriver.com>

When building with "-Og -g", we'll get errors like below:

  include/xxhash.h:5210:1: error: inlining failed in call to
  'always_inline' 'XXH3_scrambleAcc_sse2': function not considered for inlining

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 Makefile.am       | 4 ++--
 tools/debugedit.c | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index c590edf..35fd947 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -42,8 +42,8 @@ find-debuginfo: $(top_srcdir)/scripts/find-debuginfo.in Makefile
 
 debugedit_SOURCES = tools/debugedit.c \
 		    tools/hashtab.c 
-debugedit_CFLAGS = @LIBELF_CFLAGS@ @LIBDW_CFLAGS@ $(AM_CFLAGS)
-debugedit_LDADD = @LIBELF_LIBS@ @LIBDW_LIBS@
+debugedit_CFLAGS = @LIBELF_CFLAGS@ @LIBDW_CFLAGS@ @XXHASH_CFLAGS@ $(AM_CFLAGS)
+debugedit_LDADD = @LIBELF_LIBS@ @LIBDW_LIBS@ @XXHASH_LIBS@
 
 sepdebugcrcfix_SOURCES = tools/sepdebugcrcfix.c
 sepdebugcrcfix_CFLAGS = @LIBELF_CFLAGS@ $(AM_CFLAGS)
diff --git a/tools/debugedit.c b/tools/debugedit.c
index beefd65..43f9cee 100644
--- a/tools/debugedit.c
+++ b/tools/debugedit.c
@@ -82,7 +82,6 @@ typedef struct Ebl_Strtab	Strtab;
 
 #include "tools/hashtab.h"
 
-#define XXH_INLINE_ALL
 #include "xxhash.h"
 
 #define DW_TAG_partial_unit 0x3c
-- 
2.25.1



More information about the Debugedit mailing list