[COMMITTED] find-debuginfo: Fix skip_mini (".gnu_debugdata") handling

Mark Wielaard mark@klomp.org
Thu Jan 16 11:06:53 GMT 2025


The conditional that tests $skip_mini for true/false was inadvertently
flipped, causing the add_minidebug() function to no longer run for the
otherwise eligible binary files.

Fixes: 971a74d79b48 ("find-debuginfo: Check files are writable before modifying them")

Reported-by: Michal Domonkos <mdomonko@redhat.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 scripts/find-debuginfo.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
index 4e4ef5a64005..f889e6d3b574 100755
--- a/scripts/find-debuginfo.in
+++ b/scripts/find-debuginfo.in
@@ -550,7 +550,7 @@ do_file()
       application/x-executable*) skip_mini=false ;;
       application/x-pie-executable*) skip_mini=false ;;
     esac
-    if test "$skip_mini" = "true"; then
+    if test "$skip_mini" = "false"; then
       if test "$f_writable" = "false"; then
         chmod u+w "$f"
       fi
-- 
2.47.1



More information about the Debugedit mailing list