[PATCH V2] Add option to allow disabling inlined xxhash

Mark Wielaard mark@klomp.org
Wed Feb 19 10:17:31 GMT 2025


Hi,

On Tue, Feb 18, 2025 at 06:50:46PM -0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> xxhash cannot always inline. For example, when using gcc14 and
> '-Og' option, xxhash cannot inline. See links below:
> https://github.com/Cyan4973/xxHash/commit/574aabad87b2ab9440403e92e1075ef48554eb87
> https://github.com/Cyan4973/xxHash/issues/943#issuecomment-2563205130
> 
> To allow users successfully build debugedit with gcc14 and "-Og" option,
> add an option to allow disabling inlined xxhash.
> 
> This patch refers to a similar patch for libabigail:
> https://sourceware.org/cgit/libabigail/commit/?id=50497911e2590c21270e0763d277457cf7752c3f
> 
> Note that the default remains using inlined xxhash.

Looks good, thanks.  I did replace AC_HELP_STRING with AS_HELP_STRING
(AC_HELP_STRING is deprecated).

Pushed,

Mark


More information about the Debugedit mailing list