[patch] switch to xxhash for buildid recomputation

Mark Wielaard mark@klomp.org
Wed Oct 2 13:35:31 GMT 2024


Hi Frank,

On Wed, 2024-10-02 at 08:26 -0400, Frank Ch. Eigler wrote:
> > Looks good (modulo the 0.8.0 vs 0.8.1 thing discussed above).
> 
> OK, switching.  Would you like me to push it to the main branch?

Yes please!

> > P.S. Do note that sending patches in git send-email or format-patch
> > format makes it slightly easier to apply and test locally. Neither git
> > am nor b4 will recognize the diff as the proposed commit. You can apply
> > it locally with some tweaks, but it isn't really what you are about to
> > commit.
> 
> OK, FWIW, 
> 
> % curl https://inbox.sourceware.org/.../raw | git am -
> 
> is happy processing 100% of that patch, except that it puts more of
> the email prose into the commit text.

Right. It certainly isn't disastrous. Even b4 shazam <mid> will be able
to apply it, but generates a really odd looking commit message. I am
mostly mentioning this because this is one of the reasons people say
the current git/email workflow is "sloppy" (or even claim email is
broken). In this case it means you cannot easily review the actual
commit as is. And the commit message is important. It also means that
you have to do some surgery on a commit if you want to apply it for
someone. It just inhibits some automation.

Cheers,

Mark


More information about the Debugedit mailing list