[patch] switch to xxhash for buildid recomputation
Mark Wielaard
mark@klomp.org
Wed Oct 2 11:12:32 GMT 2024
HI Frank,
On Tue, 2024-10-01 at 18:45 -0400, Frank Ch. Eigler wrote:
> > > Replaced with a pkgconfig check.
> >
> > OK, but why check for libxxhash >= 0.8.2? Isn't >= 0.8.0 enough? It
> > would exclude debian stable (0.8.1) and I would really like debuginfo
> > to build on that.
>
> Even RHEL7 EPEL had 0.8.2, so I figured that was fine. I'll change it
> to 0.8.1 for our debian pals, and hope the buildbots speak up if there's
> a problem.
The buildbots only have a handful of distros and arches. There are
certainly setups out there that have different libxxhash versions
installed. We know we need at least 0.8.0, but do we need 0.8.1+? Is
there something bad in 0.8.0 so we cannot require that version?
> > > OK, v2:
> >
> > well... it is more like a diff against v1, except for the testcase?
>
> Whoops, sorry, resending.
Looks good (modulo the 0.8.0 vs 0.8.1 thing discussed above).
Thanks,
Mark
P.S. Do note that sending patches in git send-email or format-patch
format makes it slightly easier to apply and test locally. Neither git
am nor b4 will recognize the diff as the proposed commit. You can apply
it locally with some tweaks, but it isn't really what you are about to
commit.
More information about the Debugedit
mailing list