[PATCH] find-debuginfo: Check files are writable before modifying them

[Mark Wielaard]

Hi,

On Thu, 2024-11-28 at 18:12 +0100, Mark Wielaard wrote:
> Since commit dfe1f7ff3 ("find-debuginfo.sh: Exit with real exit status
> in parallel jobs") there is a check whether gdb-add-index worked
> correctly and find-debuginfo would fail (even in parallel mode) if an
> error occured.
> 
> This turned out to show that gdb-add-index needs write permission to
> add the gdb index to the file. This is also the case for a couple of
> other things, like running objcopy --merge-notes. debugedit and
> add_minidebug already made sure it had write permission.
> 
> To make sure find-debuginfo doesn't (partially) fail extend the
> writable check to include the gdb-add-index and objcopy --merge-notes
> invocation.

This has been tested in Fedora rawhide and f41 and resolved the package
building issues seen.

Added my Signed-off-by and pushed.

Cheers,

Mark