[PATCH] find-debuginfo: Pass -j down to dwz

Mark Wielaard mark@klomp.org
Thu Jan 26 23:14:35 GMT 2023


Hi Kalev,

On Thu, Jan 26, 2023 at 04:57:18PM +0100, Kalev Lember wrote:
> > I agree with Panu that a configure check would be nice to make sure the
> > installed dwz does support -j. Would the attached patch work for you?
> >
> 
> That looks perfect to me. Thanks a lot!

Pushed as:

commit 5b23e464528ef988cfcd0a87b3ec8db0520db867
Author: Kalev Lember <klember@redhat.com>
Date:   Thu Jan 19 17:03:18 2023 +0100

    find-debuginfo: Pass -j down to dwz
    
    Now that dwz 0.15 supports parallel jobs, add a way to control it from
    here. find-debuginfo already has a -j parameter so we can just extend it
    and pass the value down to dwz as well.
    
    This should fix building large packages on memory constrained builders,
    such as webkitgtk on s390x in Fedora koji build system, where we can now
    use the -j option to tune down parallelism to avoid running out of
    memory during dwz run.
    
    Add a configure check to make sure the installed dwz supports the
    -j option.
    
    Signed-off-by: Kalev Lember <klember@redhat.com>
    Signed-off-by: Mark Wielaard <mark@klomp.org>
 
> Can you also apply it to the rawhide package, please? That way I can
> confirm if it actually works on actual koji builders and see if we can get
> webkitgtk building right.

I will, but as you might have seen the rawhide buildbot just failed.
All others seem green, so it probably is the new gcc or some compiler
flag changes in fedora rawhide:
https://builder.sourceware.org/buildbot/#/changes/17730

As soon as I figure out how to get the testsuite green on rawhide I'll
also push this patch there.

Cheers,

Mark


More information about the Debugedit mailing list