From daifan@uniontech.com  Tue Jan 10 06:21:15 2023
From: daifan@uniontech.com (=?utf-8?B?5Luj5Yeh?=)
Date: Tue, 10 Jan 2023 06:21:15 +0000
Subject: 0001-debugedit-Add-support-for-loongarch
Message-ID: <tencent_398539125B6FB26304EA3933@qq.com>

From 60e47e45ced1e4c112dc043e438ca05ab1bef30b Mon Sep 17 00:00:00 2001
From: daifan <daifan@uniontech.com&gt;
Date: Tue, 10 Jan 2023 12:04:39 +0800
Subject: [PATCH] debugedit: Add support for loongarch


	* tools/debugedit.c (setup_relbuf): Handle EM_LOONGARCH
---
&nbsp;tools/debugedit.c | 6 ++++++
&nbsp;1 file changed, 6 insertions(+)


diff --git a/tools/debugedit.c b/tools/debugedit.c
index 9cb5775..b3422d7 100644
--- a/tools/debugedit.c
+++ b/tools/debugedit.c
@@ -612,6 +612,12 @@ setup_relbuf (DSO *dso, debug_section *sec, int *reltype)
&nbsp;	&nbsp; if (rtype != R_E2K_32_ABS)
&nbsp;		&nbsp; goto fail;
&nbsp;	&nbsp; break;
+#endif
+#if defined(EM_LOONGARCH) &amp;&amp; defined(R_LARCH_32)
+&nbsp; case EM_LOONGARCH:
+&nbsp; &nbsp; if (rtype != R_LARCH_32)
+&nbsp; &nbsp; &nbsp; goto fail;
+&nbsp; &nbsp; break;
&nbsp;#endif
&nbsp;	default:
&nbsp;	fail:
--&nbsp;
2.20.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/debugedit/attachments/20230110/066ae096/attachment.htm>

From mark@klomp.org  Thu Jan 12 14:48:56 2023
From: mark@klomp.org (Mark Wielaard)
Date: Thu, 12 Jan 2023 15:48:56 +0100
Subject: 0001-debugedit-Add-support-for-loongarch
In-Reply-To: <tencent_398539125B6FB26304EA3933@qq.com>
References: <tencent_398539125B6FB26304EA3933@qq.com>
Message-ID: <4fc68997ad9274e5b39c1ebac4c5d89905958516.camel@klomp.org>

Hi daifan,

On Tue, 2023-01-10 at 06:21 +0000, ?? wrote:
> diff --git a/tools/debugedit.c b/tools/debugedit.c
> index 9cb5775..b3422d7 100644
> --- a/tools/debugedit.c
> +++ b/tools/debugedit.c
> @@ -612,6 +612,12 @@ setup_relbuf (DSO *dso, debug_section *sec, int
> *reltype)
> ?	? if (rtype != R_E2K_32_ABS)
> ?		? goto fail;
> ?	? break;
> +#endif
> +#if defined(EM_LOONGARCH) && defined(R_LARCH_32)
> +? case EM_LOONGARCH:
> +? ? if (rtype != R_LARCH_32)
> +? ? ? goto fail;
> +? ? break;
> ?#endif

Thanks, that looks good. Pushed.

Cheers,

Mark

From klember@redhat.com  Thu Jan 19 16:03:18 2023
From: klember@redhat.com (Kalev Lember)
Date: Thu, 19 Jan 2023 17:03:18 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
Message-ID: <20230119160318.3868439-1-klember@redhat.com>

Now that dwz 0.15 supports parallel jobs, add a way to control it from
here. find-debuginfo already has a -j parameter so we can just extend it
and pass the value down to dwz as well.

This should fix building large packages on memory constrained builders,
such as webkitgtk on s390x in Fedora koji build system, where we can now
use the -j option to tune down parallelism to avoid running out of
memory during dwz run.

Signed-off-by: Kalev Lember <klember@redhat.com>
---
 scripts/find-debuginfo.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
index b07a52f..8cc1bfd 100755
--- a/scripts/find-debuginfo.in
+++ b/scripts/find-debuginfo.in
@@ -585,7 +585,7 @@ if $run_dwz \
       dwz_multifile_suffix=".${dwz_multifile_idx}"
     done
     dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
-    dwz_opts="-h -q -r"
+    dwz_opts="-h -q -r -j ${n_jobs}"
     [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] \
       && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
     mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"
-- 
2.39.0


From pmatilai@redhat.com  Fri Jan 20 08:39:48 2023
From: pmatilai@redhat.com (Panu Matilainen)
Date: Fri, 20 Jan 2023 10:39:48 +0200
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <20230119160318.3868439-1-klember@redhat.com>
References: <20230119160318.3868439-1-klember@redhat.com>
Message-ID: <e3240f60-2d36-a38f-99ff-c4a29b0b6b3e@redhat.com>

On 1/19/23 18:03, Kalev Lember wrote:
> Now that dwz 0.15 supports parallel jobs, add a way to control it from
> here. find-debuginfo already has a -j parameter so we can just extend it
> and pass the value down to dwz as well.
> 
> This should fix building large packages on memory constrained builders,
> such as webkitgtk on s390x in Fedora koji build system, where we can now
> use the -j option to tune down parallelism to avoid running out of
> memory during dwz run.
> 
> Signed-off-by: Kalev Lember <klember@redhat.com>
> ---
>   scripts/find-debuginfo.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> index b07a52f..8cc1bfd 100755
> --- a/scripts/find-debuginfo.in
> +++ b/scripts/find-debuginfo.in
> @@ -585,7 +585,7 @@ if $run_dwz \
>         dwz_multifile_suffix=".${dwz_multifile_idx}"
>       done
>       dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
> -    dwz_opts="-h -q -r"
> +    dwz_opts="-h -q -r -j ${n_jobs}"
>       [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] \
>         && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
>       mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"

This is so new, even Fedora 37 doesn't have it yet. I tend to think 
find-debuginfo should be a bit conservative about the assumptions it 
makes about external tools.

	- Panu -


From klember@redhat.com  Fri Jan 20 10:27:35 2023
From: klember@redhat.com (Kalev Lember)
Date: Fri, 20 Jan 2023 11:27:35 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <e3240f60-2d36-a38f-99ff-c4a29b0b6b3e@redhat.com>
References: <20230119160318.3868439-1-klember@redhat.com>
 <e3240f60-2d36-a38f-99ff-c4a29b0b6b3e@redhat.com>
Message-ID: <CAHjaNbrcJUy1HZ1sp+CUzqAk2nuY9P5g+_gMd_dhvGm4-KG2+w@mail.gmail.com>

On Fri, Jan 20, 2023 at 9:40 AM Panu Matilainen <pmatilai@redhat.com> wrote:

> On 1/19/23 18:03, Kalev Lember wrote:
> > Now that dwz 0.15 supports parallel jobs, add a way to control it from
> > here. find-debuginfo already has a -j parameter so we can just extend it
> > and pass the value down to dwz as well.
> >
> > This should fix building large packages on memory constrained builders,
> > such as webkitgtk on s390x in Fedora koji build system, where we can now
> > use the -j option to tune down parallelism to avoid running out of
> > memory during dwz run.
> >
> > Signed-off-by: Kalev Lember <klember@redhat.com>
> > ---
> >   scripts/find-debuginfo.in | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> > index b07a52f..8cc1bfd 100755
> > --- a/scripts/find-debuginfo.in
> > +++ b/scripts/find-debuginfo.in
> > @@ -585,7 +585,7 @@ if $run_dwz \
> >         dwz_multifile_suffix=".${dwz_multifile_idx}"
> >       done
> >       dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
> > -    dwz_opts="-h -q -r"
> > +    dwz_opts="-h -q -r -j ${n_jobs}"
> >       [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false"
> ] \
> >         && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
> >       mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"
>
> This is so new, even Fedora 37 doesn't have it yet. I tend to think
> find-debuginfo should be a bit conservative about the assumptions it
> makes about external tools.
>

Can we do some kind of configure check then and require the latest dwz? Or
add this as a downstream patch in rawhide?

The problem is that new dwz is already in rawhide and it broke webkitgtk
builds due to too much memory use. The ppc64le and s390x builders just
don't have enough memory now to do dwz on webkitgtk. Passing down the -j
option would help us control the memory use to get the builds going again.

Meanwhile we worked this around by completely disabling the dwz
optimization for webkitgtk, but it would be nice to get it back to working.

See
https://src.fedoraproject.org/rpms/webkitgtk/c/2c5dd84529070a8cfb0c6599dee587ca8fbcb6d2?branch=rawhide

-- 
Thanks,
Kalev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/debugedit/attachments/20230120/1e739dcf/attachment.htm>

From pmatilai@redhat.com  Fri Jan 20 11:27:39 2023
From: pmatilai@redhat.com (Panu Matilainen)
Date: Fri, 20 Jan 2023 13:27:39 +0200
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <CAHjaNbrcJUy1HZ1sp+CUzqAk2nuY9P5g+_gMd_dhvGm4-KG2+w@mail.gmail.com>
References: <20230119160318.3868439-1-klember@redhat.com>
 <e3240f60-2d36-a38f-99ff-c4a29b0b6b3e@redhat.com>
 <CAHjaNbrcJUy1HZ1sp+CUzqAk2nuY9P5g+_gMd_dhvGm4-KG2+w@mail.gmail.com>
Message-ID: <b4e0162f-dfbd-968f-8d35-14b18bacf8b4@redhat.com>

On 1/20/23 12:27, Kalev Lember wrote:
> On Fri, Jan 20, 2023 at 9:40 AM Panu Matilainen <pmatilai@redhat.com 
> <mailto:pmatilai@redhat.com>> wrote:
> 
>     On 1/19/23 18:03, Kalev Lember wrote:
>      > Now that dwz 0.15 supports parallel jobs, add a way to control it
>     from
>      > here. find-debuginfo already has a -j parameter so we can just
>     extend it
>      > and pass the value down to dwz as well.
>      >
>      > This should fix building large packages on memory constrained
>     builders,
>      > such as webkitgtk on s390x in Fedora koji build system, where we
>     can now
>      > use the -j option to tune down parallelism to avoid running out of
>      > memory during dwz run.
>      >
>      > Signed-off-by: Kalev Lember <klember@redhat.com
>     <mailto:klember@redhat.com>>
>      > ---
>      >? ?scripts/find-debuginfo.in <http://find-debuginfo.in> | 2 +-
>      >? ?1 file changed, 1 insertion(+), 1 deletion(-)
>      >
>      > diff --git a/scripts/find-debuginfo.in <http://find-debuginfo.in>
>     b/scripts/find-debuginfo.in <http://find-debuginfo.in>
>      > index b07a52f..8cc1bfd 100755
>      > --- a/scripts/find-debuginfo.in <http://find-debuginfo.in>
>      > +++ b/scripts/find-debuginfo.in <http://find-debuginfo.in>
>      > @@ -585,7 +585,7 @@ if $run_dwz \
>      >? ? ? ? ?dwz_multifile_suffix=".${dwz_multifile_idx}"
>      >? ? ? ?done
>      >     
>      ?dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
>      > -? ? dwz_opts="-h -q -r"
>      > +? ? dwz_opts="-h -q -r -j ${n_jobs}"
>      >? ? ? ?[ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" =
>     "false" ] \
>      >? ? ? ? ?&& dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
>      >? ? ? ?mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"
> 
>     This is so new, even Fedora 37 doesn't have it yet. I tend to think
>     find-debuginfo should be a bit conservative about the assumptions it
>     makes about external tools.
> 
> 
> Can we do some kind of configure check then and require the latest?dwz? 
> Or add this as a downstream patch in rawhide?
> 
> The problem is that new dwz is already in rawhide and it broke webkitgtk 
> builds due to too much memory use. The ppc64le and s390x builders just 
> don't have enough memory now to?do?dwz on webkitgtk. Passing down the -j 
> option would help us control the memory use to get the builds going again.
> 

Oh, if rawhide needs this then rawhide needs this, I don't mind that at 
all. I just think that upstream find-debuginfo shouldn't assume "latest 
everything" any more than rpm can do so.

configure-time check seems reasonable to me.

	- Panu -


From prarit@redhat.com  Mon Jan 23 20:27:37 2023
From: prarit@redhat.com (Prarit Bhargava)
Date: Mon, 23 Jan 2023 15:27:37 -0500
Subject: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg
Message-ID: <20230123202737.3632441-1-prarit@redhat.com>

Projects with a large number of compiled files end up with a large number
of 'extracting debug info from' messages in the build log.  In the case of
the Fedora kernel these messages account for 8504 lines in the log, or 61%
of the entire log [1].

Removing these lines make the log easier to view and comprehend for some
projects, however, not all projects will want to silence these messages so
suppressing them must be optional.

Add a --no-per-file-msg which allows users to disable the per file
scanning message and in its place output a single general message in the
log.

[1] https://kojipkgs.fedoraproject.org//packages/kernel/6.2.0/0.rc5.20230123git2475bf0250de.38.fc38/data/logs/x86_64/build.log

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
 scripts/find-debuginfo.in | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
index b07a52fe4b98..f262b00cfcb1 100755
--- a/scripts/find-debuginfo.in
+++ b/scripts/find-debuginfo.in
@@ -38,6 +38,7 @@ Options:
 [--build-id-seed SEED]
 [--unique-debug-suffix SUFFIX]
 [--unique-debug-src-base BASE]
+[--no-per-file-msg]
 [[-l filelist]... [-p 'pattern'] -o debuginfo.list]
 [builddir]
 
@@ -94,6 +95,9 @@ will be called /usr/debug/src/<BASE>.  This makes sure the debug source
 dirs are unique between package version, release and achitecture (Use
 --unique-debug-src-base "%{name}-%{VERSION}-%{RELEASE}.%{_arch}")
 
+If --no-per-file-msg is given then the 'extract debuginfo from ...'
+message is not output for each file.
+
 All file names in switches are relative to builddir ('.' if not given).
 EOF
 }
@@ -146,6 +150,9 @@ n_jobs=1
 # exit early on --version or --help
 done=false
 
+# Output the "extracting debug info from" message for each file.
+per_file_msg=true
+
 BUILDDIR=.
 out=debugfiles.list
 srcout=
@@ -239,6 +246,9 @@ while [ $# -gt 0 ]; do
     srcout=$2
     shift
     ;;
+  --no-per-file-msg)
+    per_file_msg=false
+    ;;
   --version)
     echo "find-debuginfo @VERSION@"
     done=true;
@@ -437,7 +447,7 @@ do_file()
   get_debugfn "$f"
   [ -f "${debugfn}" ] && return
 
-  echo "extracting debug info from $f"
+  $per_file_msg && echo "extracting debug info from $f"
   # See also cpio SOURCEFILE copy. Directories must match up.
   debug_base_name="$RPM_BUILD_DIR"
   debug_dest_name="/usr/src/debug"
@@ -544,6 +554,7 @@ n_files=$(wc -l <"$temp/primary")
 if [ $n_jobs -gt $n_files ]; then
   n_jobs=$n_files
 fi
+$per_file_msg || echo "Extracting debuginfo from files ..."
 if [ $n_jobs -le 1 ]; then
   while read nlinks inum f; do
     do_file "$nlinks" "$inum" "$f"
-- 
2.39.1


From mark@klomp.org  Thu Jan 26 14:34:12 2023
From: mark@klomp.org (Mark Wielaard)
Date: Thu, 26 Jan 2023 15:34:12 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <20230119160318.3868439-1-klember@redhat.com>
References: <20230119160318.3868439-1-klember@redhat.com>
Message-ID: <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>

Hi Kalev,

On Thu, 2023-01-19 at 17:03 +0100, Kalev Lember wrote:
> Now that dwz 0.15 supports parallel jobs, add a way to control it from
> here. find-debuginfo already has a -j parameter so we can just extend it
> and pass the value down to dwz as well.
> 
> This should fix building large packages on memory constrained builders,
> such as webkitgtk on s390x in Fedora koji build system, where we can now
> use the -j option to tune down parallelism to avoid running out of
> memory during dwz run.

Aha, you want to reduce the default parallelism (processors / 2)?

> diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> index b07a52f..8cc1bfd 100755
> --- a/scripts/find-debuginfo.in
> +++ b/scripts/find-debuginfo.in
> @@ -585,7 +585,7 @@ if $run_dwz \
>        dwz_multifile_suffix=".${dwz_multifile_idx}"
>      done
>      dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
> -    dwz_opts="-h -q -r"
> +    dwz_opts="-h -q -r -j ${n_jobs}"
>      [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ] \
>        && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
>      mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"

I agree with Panu that a configure check would be nice to make sure the
installed dwz does support -j. Would the attached patch work for you?

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dwz_j.patch
Type: text/x-patch
Size: 2047 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/debugedit/attachments/20230126/e6321efc/attachment.bin>

From mark@klomp.org  Thu Jan 26 15:02:50 2023
From: mark@klomp.org (Mark Wielaard)
Date: Thu, 26 Jan 2023 16:02:50 +0100
Subject: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg
In-Reply-To: <20230123202737.3632441-1-prarit@redhat.com>
References: <20230123202737.3632441-1-prarit@redhat.com>
Message-ID: <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org>

Hi Prarit,

On Mon, 2023-01-23 at 15:27 -0500, Prarit Bhargava wrote:
> Projects with a large number of compiled files end up with a large number
> of 'extracting debug info from' messages in the build log.  In the case of
> the Fedora kernel these messages account for 8504 lines in the log, or 61%
> of the entire log [1].
> 
> Removing these lines make the log easier to view and comprehend for some
> projects, however, not all projects will want to silence these messages so
> suppressing them must be optional.
>
> Add a --no-per-file-msg which allows users to disable the per file
> scanning message and in its place output a single general message in the
> log.

I appreciate the idea, but I think it is better to have a more standard
-q, --quiet option that simply suppresses all none error/warnings.?
find-debuginfo already has too many specialized options IMHO.

Besides this "per file" output that is just these three extra output
lines:

  echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug"
  echo "hard linked $link to $debugfn"
  echo "original debug info size: ${size_before}kB, size after
compression: ${size_after}kB"

(For that last one, you can then also hide the size_before
 and size_after calculations behind $quiet &&)

Cheers,

Mark

From prarit@redhat.com  Thu Jan 26 15:21:36 2023
From: prarit@redhat.com (Prarit Bhargava)
Date: Thu, 26 Jan 2023 10:21:36 -0500
Subject: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg
In-Reply-To: <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org>
References: <20230123202737.3632441-1-prarit@redhat.com>
 <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org>
Message-ID: <b2c776d8-39fe-07bd-d644-62bacafc6796@redhat.com>

On 1/26/23 10:02, Mark Wielaard wrote:
> Hi Prarit,
> 
> On Mon, 2023-01-23 at 15:27 -0500, Prarit Bhargava wrote:
>> Projects with a large number of compiled files end up with a large number
>> of 'extracting debug info from' messages in the build log.  In the case of
>> the Fedora kernel these messages account for 8504 lines in the log, or 61%
>> of the entire log [1].
>>
>> Removing these lines make the log easier to view and comprehend for some
>> projects, however, not all projects will want to silence these messages so
>> suppressing them must be optional.
>>
>> Add a --no-per-file-msg which allows users to disable the per file
>> scanning message and in its place output a single general message in the
>> log.
> 
> I appreciate the idea, but I think it is better to have a more standard
> -q, --quiet option that simply suppresses all none error/warnings.
> find-debuginfo already has too many specialized options IMHO.
> 

Heh, I thought about doing this but wasn't sure if there needed to be a 
quiet option.  It's good to know you're open to this idea.

> Besides this "per file" output that is just these three extra output
> lines:
> 
>    echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug"
>    echo "hard linked $link to $debugfn"
>    echo "original debug info size: ${size_before}kB, size after
> compression: ${size_after}kB"
> 

> (For that last one, you can then also hide the size_before
>   and size_after calculations behind $quiet &&)

I'll look at this and post a --quiet option.

Thanks,

P.


From klember@redhat.com  Thu Jan 26 15:57:18 2023
From: klember@redhat.com (Kalev Lember)
Date: Thu, 26 Jan 2023 16:57:18 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>
References: <20230119160318.3868439-1-klember@redhat.com>
 <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>
Message-ID: <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>

On Thu, Jan 26, 2023 at 3:34 PM Mark Wielaard <mark@klomp.org> wrote:

> Hi Kalev,
>

Hi Mark,


> Aha, you want to reduce the default parallelism (processors / 2)?
>

Yes, exactly!

We have the following in webkitgtk, which basically just passes -j1 on low
memory builders:

# Require 32 GB of RAM per vCPU for debuginfo processing. 16 GB is not
enough.
%global _find_debuginfo_opts %limit_build -m 32768


> diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
> > index b07a52f..8cc1bfd 100755
> > --- a/scripts/find-debuginfo.in
> > +++ b/scripts/find-debuginfo.in
> > @@ -585,7 +585,7 @@ if $run_dwz \
> >        dwz_multifile_suffix=".${dwz_multifile_idx}"
> >      done
> >      dwz_multifile_name="${dwz_multifile_name}${dwz_multifile_suffix}"
> > -    dwz_opts="-h -q -r"
> > +    dwz_opts="-h -q -r -j ${n_jobs}"
> >      [ ${#dwz_files[@]} -gt 1 ] && [ "$dwz_single_file_mode" = "false" ]
> \
> >        && dwz_opts="${dwz_opts} -m .dwz/${dwz_multifile_name}"
> >      mkdir -p "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz"
>
> I agree with Panu that a configure check would be nice to make sure the
> installed dwz does support -j. Would the attached patch work for you?
>

That looks perfect to me. Thanks a lot!

Can you also apply it to the rawhide package, please? That way I can
confirm if it actually works on actual koji builders and see if we can get
webkitgtk building right.

Thanks,
Kalev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/debugedit/attachments/20230126/ae39c081/attachment.htm>

From prarit@redhat.com  Thu Jan 26 21:08:57 2023
From: prarit@redhat.com (Prarit Bhargava)
Date: Thu, 26 Jan 2023 16:08:57 -0500
Subject: [PATCH] scripts/find-debuginfo.in: Add -q|--quiet
Message-ID: <20230126210857.3867040-1-prarit@redhat.com>

Projects with a large number of compiled files end up with a large number
of 'extracting debug info from' messages in the build log.  In the case of
the Fedora kernel these messages account for 8504 lines in the log, or 61%
of the entire log [1].

Removing these lines make the log easier to view and comprehend for some
projects, however, not all projects will want to silence these messages so
suppressing them must be optional.

Add a -q|--quiet which allows users to silence the non-error output from
the script.

[1] https://kojipkgs.fedoraproject.org//packages/kernel/6.2.0/0.rc5.20230123git2475bf0250de.38.fc38/data/logs/x86_64/build.log

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
 scripts/find-debuginfo.in | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/scripts/find-debuginfo.in b/scripts/find-debuginfo.in
index b07a52fe4b98..e55a62cc78f1 100755
--- a/scripts/find-debuginfo.in
+++ b/scripts/find-debuginfo.in
@@ -26,7 +26,7 @@ Usage: find-debuginfo [OPTION]... [builddir]
 automagically generates debug info and file lists
 
 Options:
-[--strict-build-id] [-g] [-r] [-m] [-i] [-n]
+[--strict-build-id] [-g] [-r] [-m] [-i] [-n] [-q]
 [--keep-section SECTION] [--remove-section SECTION]
 [--g-libs]
 [-j N] [--jobs N]
@@ -94,6 +94,8 @@ will be called /usr/debug/src/<BASE>.  This makes sure the debug source
 dirs are unique between package version, release and achitecture (Use
 --unique-debug-src-base "%{name}-%{VERSION}-%{RELEASE}.%{_arch}")
 
+The -q or --quiet flag silences non-error output from the script.
+
 All file names in switches are relative to builddir ('.' if not given).
 EOF
 }
@@ -146,6 +148,9 @@ n_jobs=1
 # exit early on --version or --help
 done=false
 
+# silence non-error output
+quiet=false
+
 BUILDDIR=.
 out=debugfiles.list
 srcout=
@@ -239,6 +244,9 @@ while [ $# -gt 0 ]; do
     srcout=$2
     shift
     ;;
+  -q|--quiet)
+    quiet=true
+    ;;
   --version)
     echo "find-debuginfo @VERSION@"
     done=true;
@@ -437,7 +445,7 @@ do_file()
   get_debugfn "$f"
   [ -f "${debugfn}" ] && return
 
-  echo "extracting debug info from $f"
+  $quiet || echo "extracting debug info from $f"
   # See also cpio SOURCEFILE copy. Directories must match up.
   debug_base_name="$RPM_BUILD_DIR"
   debug_dest_name="/usr/src/debug"
@@ -513,7 +521,7 @@ do_file()
     grep "^$inum " "$temp/linked" | while read inum linked; do
       link=$debugfn
       get_debugfn "$linked"
-      echo "hard linked $link to $debugfn"
+      $quiet || echo "hard linked $link to $debugfn"
       mkdir -p "$(dirname "$debugfn")" && ln -nf "$link" "$debugfn"
     done
   fi
@@ -576,7 +584,7 @@ if $run_dwz \
    && [ -d "${RPM_BUILD_ROOT}/usr/lib/debug" ]; then
   readarray dwz_files < <(cd "${RPM_BUILD_ROOT}/usr/lib/debug"; find -type f -name \*.debug | LC_ALL=C sort)
   if [ ${#dwz_files[@]} -gt 0 ]; then
-    size_before=$(du -sk ${RPM_BUILD_ROOT}/usr/lib/debug | cut -f1)
+    $quiet || size_before=$(du -sk ${RPM_BUILD_ROOT}/usr/lib/debug | cut -f1)
     dwz_multifile_name="${RPM_PACKAGE_NAME}-${RPM_PACKAGE_VERSION}-${RPM_PACKAGE_RELEASE}.${RPM_ARCH}"
     dwz_multifile_suffix=
     dwz_multifile_idx=0
@@ -599,8 +607,8 @@ if $run_dwz \
       echo >&2 "*** ERROR: DWARF compression requested, but no dwz installed"
       exit 2
     fi
-    size_after=$(du -sk ${RPM_BUILD_ROOT}/usr/lib/debug | cut -f1)
-    echo "original debug info size: ${size_before}kB, size after compression: ${size_after}kB"
+    $quiet || size_after=$(du -sk ${RPM_BUILD_ROOT}/usr/lib/debug | cut -f1)
+    $quiet || echo "original debug info size: ${size_before}kB, size after compression: ${size_after}kB"
     # Remove .dwz directory if empty
     rmdir "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz" 2>/dev/null
 
@@ -620,7 +628,7 @@ do
   f=${f#$RPM_BUILD_ROOT}
   t=${t#$RPM_BUILD_ROOT}
   if [ -f "$debugdir$t" ]; then
-    echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug"
+    $quiet || echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug"
     debug_link "/usr/lib/debug$t" "${f}.debug"
   fi
 done
-- 
2.39.1


From builder@sourceware.org  Thu Jan 26 22:58:47 2023
From: builder@sourceware.org (builder@sourceware.org)
Date: Thu, 26 Jan 2023 22:58:47 +0000
Subject: =?utf-8?q?=E2=98=A0_Buildbot_=28Sourceware=29=3A_debugedit_-_failed_test_=28failure=29_test_=28failure=29_=28main=29?=
Message-ID: <20230126225847.DCD913858D28@sourceware.org>

A new failure has been detected on builder debugedit-rawhide-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/137/builds/3

Build state: failed test (failure) test (failure)
Revision: 5b23e464528ef988cfcd0a87b3ec8db0520db867
Worker: bb1-1
Build Reason: (unknown)
Blamelist: Kalev Lember <klember@redhat.com>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/6/logs/stdio

- 7: make check ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/7/logs/stdio
        - test-suite.log: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/7/logs/test-suite_log

- 8: make distcheck ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/8/logs/stdio
        - test-suite.log: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/8/logs/test-suite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/3/steps/19/logs/stdio


From mark@klomp.org  Thu Jan 26 23:14:35 2023
From: mark@klomp.org (Mark Wielaard)
Date: Fri, 27 Jan 2023 00:14:35 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>
References: <20230119160318.3868439-1-klember@redhat.com>
 <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>
 <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>
Message-ID: <20230126231435.GA21676@gnu.wildebeest.org>

Hi Kalev,

On Thu, Jan 26, 2023 at 04:57:18PM +0100, Kalev Lember wrote:
> > I agree with Panu that a configure check would be nice to make sure the
> > installed dwz does support -j. Would the attached patch work for you?
> >
> 
> That looks perfect to me. Thanks a lot!

Pushed as:

commit 5b23e464528ef988cfcd0a87b3ec8db0520db867
Author: Kalev Lember <klember@redhat.com>
Date:   Thu Jan 19 17:03:18 2023 +0100

    find-debuginfo: Pass -j down to dwz
    
    Now that dwz 0.15 supports parallel jobs, add a way to control it from
    here. find-debuginfo already has a -j parameter so we can just extend it
    and pass the value down to dwz as well.
    
    This should fix building large packages on memory constrained builders,
    such as webkitgtk on s390x in Fedora koji build system, where we can now
    use the -j option to tune down parallelism to avoid running out of
    memory during dwz run.
    
    Add a configure check to make sure the installed dwz supports the
    -j option.
    
    Signed-off-by: Kalev Lember <klember@redhat.com>
    Signed-off-by: Mark Wielaard <mark@klomp.org>
 
> Can you also apply it to the rawhide package, please? That way I can
> confirm if it actually works on actual koji builders and see if we can get
> webkitgtk building right.

I will, but as you might have seen the rawhide buildbot just failed.
All others seem green, so it probably is the new gcc or some compiler
flag changes in fedora rawhide:
https://builder.sourceware.org/buildbot/#/changes/17730

As soon as I figure out how to get the testsuite green on rawhide I'll
also push this patch there.

Cheers,

Mark

From mark@klomp.org  Fri Jan 27 14:26:26 2023
From: mark@klomp.org (Mark Wielaard)
Date: Fri, 27 Jan 2023 15:26:26 +0100
Subject: [COMMITTED] configure.ac: Use AC_LINK_IFELSE for -gz=none check
Message-ID: <20230127142626.14725-1-mark@klomp.org>

Because of a bug in gcc 13.0 (pre-release) -gz=none does not work
correctly when linking the final binary in some situations (when
-gz=zstd isn't supported). Work around this by explicitly checking for
support with AC_LINK_IFELSE.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108572

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index f2d1571..1d77e99 100644
--- a/configure.ac
+++ b/configure.ac
@@ -125,7 +125,7 @@ AC_SUBST([DWARF_5_DEBUGLINE])
 AC_CACHE_CHECK([whether gcc supports -gz=none], ac_cv_gz_none, [dnl
 save_CFLAGS="$CFLAGS"
 CFLAGS="-gz=none"
-AC_COMPILE_IFELSE([AC_LANG_SOURCE()], ac_cv_gz_none=yes, ac_cv_gz_none=no)
+AC_LINK_IFELSE([AC_LANG_SOURCE()], ac_cv_gz_none=yes, ac_cv_gz_none=no)
 CFLAGS="$save_CFLAGS"
 ])
 if test "$ac_cv_gz_none" = "yes"; then
-- 
2.39.1


From builder@sourceware.org  Fri Jan 27 14:31:38 2023
From: builder@sourceware.org (builder@sourceware.org)
Date: Fri, 27 Jan 2023 14:31:38 +0000
Subject: =?utf-8?q?=E2=98=A0_Buildbot_=28Sourceware=29=3A_debugedit_-_failed_test_=28failure=29_test_=28failure=29_=28main=29?=
Message-ID: <20230127143138.463E43858002@sourceware.org>

A new failure has been detected on builder debugedit-opensusetw-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/91/builds/4

Build state: failed test (failure) test (failure)
Revision: 73652fa06c449f55b844890778c4cb592e0df62e
Worker: bbo1-2
Build Reason: (unknown)
Blamelist: Mark Wielaard <mark@klomp.org>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/6/logs/stdio

- 7: make check ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/7/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/7/logs/testsuite_log

- 8: make distcheck ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/8/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/8/logs/testsuite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/4/steps/19/logs/stdio

A new failure has been detected on builder debugedit-opensuseleap-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/95/builds/4

Build state: failed test (failure) test (failure)
Revision: 73652fa06c449f55b844890778c4cb592e0df62e
Worker: bbo1-1
Build Reason: (unknown)
Blamelist: Mark Wielaard <mark@klomp.org>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/6/logs/stdio

- 7: make check ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/7/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/7/logs/testsuite_log

- 8: make distcheck ( failure )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/8/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/8/logs/testsuite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/4/steps/19/logs/stdio

A restored build has been detected on builder debugedit-rawhide-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/137/builds/5

Build state: build successful
Revision: 73652fa06c449f55b844890778c4cb592e0df62e
Worker: bb2-2
Build Reason: (unknown)
Blamelist: Kalev Lember <klember@redhat.com>, Mark Wielaard <mark@klomp.org>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/6/logs/stdio

- 7: make check ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/7/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/7/logs/testsuite_log

- 8: make distcheck ( warnings )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/8/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/8/logs/testsuite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/137/builds/5/steps/19/logs/stdio


From mark@klomp.org  Fri Jan 27 16:05:58 2023
From: mark@klomp.org (Mark Wielaard)
Date: Fri, 27 Jan 2023 17:05:58 +0100
Subject: [COMMITTED] configure.ac: Use AC_LANG_PROGRAM for AC_LINK_IFELSE
 -gz=none check
Message-ID: <20230127160558.19973-1-mark@klomp.org>

We do need a real AC_LANG_PROGRAM instead of just AC_LANG_SOURCE since
commit 73652f configure.ac: Use AC_LINK_IFELSE for -gz=none check

Otherwise the check always fails because it will not have a main ().

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 1d77e99..6704dc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -125,7 +125,7 @@ AC_SUBST([DWARF_5_DEBUGLINE])
 AC_CACHE_CHECK([whether gcc supports -gz=none], ac_cv_gz_none, [dnl
 save_CFLAGS="$CFLAGS"
 CFLAGS="-gz=none"
-AC_LINK_IFELSE([AC_LANG_SOURCE()], ac_cv_gz_none=yes, ac_cv_gz_none=no)
+AC_LINK_IFELSE([AC_LANG_PROGRAM()], ac_cv_gz_none=yes, ac_cv_gz_none=no)
 CFLAGS="$save_CFLAGS"
 ])
 if test "$ac_cv_gz_none" = "yes"; then
-- 
2.39.1


From builder@sourceware.org  Fri Jan 27 16:10:23 2023
From: builder@sourceware.org (builder@sourceware.org)
Date: Fri, 27 Jan 2023 16:10:23 +0000
Subject: =?utf-8?q?=E2=98=BA_Buildbot_=28Sourceware=29=3A_debugedit_-_build_successful_=28main=29?=
Message-ID: <20230127161023.439B03858C00@sourceware.org>

A restored build has been detected on builder debugedit-opensusetw-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/91/builds/5

Build state: build successful
Revision: c206186e015aca89af2bb058f37e9db81160965e
Worker: bb1-1
Build Reason: (unknown)
Blamelist: Mark Wielaard <mark@klomp.org>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/6/logs/stdio

- 7: make check ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/7/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/7/logs/testsuite_log

- 8: make distcheck ( warnings )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/8/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/8/logs/testsuite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/91/builds/5/steps/19/logs/stdio

A restored build has been detected on builder debugedit-opensuseleap-x86_64 while building debugedit.

Full details are available at:
    https://builder.sourceware.org/buildbot/#builders/95/builds/5

Build state: build successful
Revision: c206186e015aca89af2bb058f37e9db81160965e
Worker: bbo1-1
Build Reason: (unknown)
Blamelist: Mark Wielaard <mark@klomp.org>

Steps:

- 0: worker_preparation ( success )

- 1: set package name ( success )

- 2: git checkout ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/2/logs/stdio

- 3: autoreconf ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/3/logs/stdio

- 4: configure ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/4/logs/stdio

- 5: get version ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/5/logs/stdio
        - property changes: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/5/logs/property_changes

- 6: make ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/6/logs/stdio

- 7: make check ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/7/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/7/logs/testsuite_log

- 8: make distcheck ( warnings )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/8/logs/stdio
        - testsuite.log: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/8/logs/testsuite_log
        - warnings (1): https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/8/logs/warnings__1_

- 9: prep ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/9/logs/stdio

- 10: build bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/10/logs/stdio

- 11: fetch bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/11/logs/stdio

- 12: unpack bunsen.cpio.gz ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/12/logs/stdio

- 13: pass .bunsen.source.gitname ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/13/logs/stdio

- 14: pass .bunsen.source.gitdescribe ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/14/logs/stdio

- 15: pass .bunsen.source.gitbranch ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/15/logs/stdio

- 16: pass .bunsen.source.gitrepo ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/16/logs/stdio

- 17: upload to bunsen ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/17/logs/stdio

- 18: clean up ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/18/logs/stdio

- 19: make clean ( success )
    Logs:
        - stdio: https://builder.sourceware.org/buildbot/#builders/95/builds/5/steps/19/logs/stdio


From mark@klomp.org  Fri Jan 27 17:37:38 2023
From: mark@klomp.org (Mark Wielaard)
Date: Fri, 27 Jan 2023 18:37:38 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <20230126231435.GA21676@gnu.wildebeest.org>
References: <20230119160318.3868439-1-klember@redhat.com>
 <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>
 <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>
 <20230126231435.GA21676@gnu.wildebeest.org>
Message-ID: <176e53d0a94aa24662bd502e93d8b44a7db746dc.camel@klomp.org>

Hi Kalev,

On Fri, 2023-01-27 at 00:14 +0100, Mark Wielaard wrote:
> > Can you also apply it to the rawhide package, please? That way I can
> > confirm if it actually works on actual koji builders and see if we can get
> > webkitgtk building right.
> 
> I will, but as you might have seen the rawhide buildbot just failed.
> All others seem green, so it probably is the new gcc or some compiler
> flag changes in fedora rawhide:
> https://builder.sourceware.org/buildbot/#/changes/17730
> 
> As soon as I figure out how to get the testsuite green on rawhide I'll
> also push this patch there.

Figured it out. It was actually a bug in gcc 13.0 prerelease. Committed
a workaround (and a fix for the workaround, sigh) and ported that and
the dwz -j patch to the Fedora rawhide package debugedit-5.0-7.fc38 so
you can test it out there.

Cheers,

Mark

From mark@klomp.org  Fri Jan 27 17:38:07 2023
From: mark@klomp.org (Mark Wielaard)
Date: Fri, 27 Jan 2023 18:38:07 +0100
Subject: [PATCH] scripts/find-debuginfo.in: Add -q|--quiet
In-Reply-To: <20230126210857.3867040-1-prarit@redhat.com>
References: <20230126210857.3867040-1-prarit@redhat.com>
Message-ID: <16f282cf1aef62db202c3cc8902b406dae08e9bc.camel@klomp.org>

Hi Prarit,

On Thu, 2023-01-26 at 16:08 -0500, Prarit Bhargava wrote:
> Projects with a large number of compiled files end up with a large number
> of 'extracting debug info from' messages in the build log.  In the case of
> the Fedora kernel these messages account for 8504 lines in the log, or 61%
> of the entire log [1].
> 
> Removing these lines make the log easier to view and comprehend for some
> projects, however, not all projects will want to silence these messages so
> suppressing them must be optional.
> 
> Add a -q|--quiet which allows users to silence the non-error output from
> the script.

Looks perfect. Applied as is. Also backported to Fedora rawhide package
debugedit-5.0-7.fc38 so you can test it out there.

Thanks,

Mark

From klember@redhat.com  Sat Jan 28 01:07:25 2023
From: klember@redhat.com (Kalev Lember)
Date: Sat, 28 Jan 2023 02:07:25 +0100
Subject: [PATCH] find-debuginfo: Pass -j down to dwz
In-Reply-To: <176e53d0a94aa24662bd502e93d8b44a7db746dc.camel@klomp.org>
References: <20230119160318.3868439-1-klember@redhat.com>
 <3fa74c6c1f99765430b0e041c050d47b0a993aec.camel@klomp.org>
 <CAHjaNbrVQNhLdtJDdcg4gn3rFWh0KjYReavVjdNwLQDfp8UfWA@mail.gmail.com>
 <20230126231435.GA21676@gnu.wildebeest.org>
 <176e53d0a94aa24662bd502e93d8b44a7db746dc.camel@klomp.org>
Message-ID: <CAHjaNbpNTMU7OZiH1TacWV+zGjM9R7gEpiJiPFUzgzz3nL_7fw@mail.gmail.com>

Hi Mark,

On Fri, Jan 27, 2023 at 6:37 PM Mark Wielaard <mark@klomp.org> wrote:

> Figured it out. It was actually a bug in gcc 13.0 prerelease. Committed
> a workaround (and a fix for the workaround, sigh) and ported that and
> the dwz -j patch to the Fedora rawhide package debugedit-5.0-7.fc38 so
> you can test it out there.
>

Thank you! I did a webkitgtk scratch build and it looks like the fix works
as expected.

-- 
Kalev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/debugedit/attachments/20230128/85c9e5e2/attachment.htm>

From prarit@redhat.com  Sat Jan 28 13:24:06 2023
From: prarit@redhat.com (Prarit Bhargava)
Date: Sat, 28 Jan 2023 08:24:06 -0500
Subject: [PATCH] scripts/find-debuginfo.in: Add -q|--quiet
In-Reply-To: <16f282cf1aef62db202c3cc8902b406dae08e9bc.camel@klomp.org>
References: <20230126210857.3867040-1-prarit@redhat.com>
 <16f282cf1aef62db202c3cc8902b406dae08e9bc.camel@klomp.org>
Message-ID: <92604e62-0121-dd93-a7f6-a86bd01dc0dd@redhat.com>

On 1/27/23 12:38, Mark Wielaard wrote:
> Hi Prarit,
> 
> On Thu, 2023-01-26 at 16:08 -0500, Prarit Bhargava wrote:
>> Projects with a large number of compiled files end up with a large number
>> of 'extracting debug info from' messages in the build log.  In the case of
>> the Fedora kernel these messages account for 8504 lines in the log, or 61%
>> of the entire log [1].
>>
>> Removing these lines make the log easier to view and comprehend for some
>> projects, however, not all projects will want to silence these messages so
>> suppressing them must be optional.
>>
>> Add a -q|--quiet which allows users to silence the non-error output from
>> the script.
> 
> Looks perfect. Applied as is. Also backported to Fedora rawhide package
> debugedit-5.0-7.fc38 so you can test it out there.
> 

Thanks.  LGTM.  Is there any chance you could also create packages for 
F37 and F36?

https://src.fedoraproject.org/rpms/debugedit

I'd like to add --quiet to the kernel.spec but cannot do so until the 
fix reaches all supported fedora releases.

P.

> Thanks,
> 
> Mark
> 


From mark@klomp.org  Sat Jan 28 19:55:10 2023
From: mark@klomp.org (Mark Wielaard)
Date: Sat, 28 Jan 2023 20:55:10 +0100
Subject: [COMMITTED] configure.ac: Update AC_PROG_CC for autoconf 2.70
Message-ID: <20230128195509.101200-1-mark@klomp.org>

With autoconf 2.70 we must use AC_PROG_CC (which will check for
c11 and c99), for earlier versions we'll use AC_PROG_CC_C99.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6704dc0..c887aed 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,7 +41,7 @@ AC_USE_SYSTEM_EXTENSIONS
 # Checks for programs.
 AC_PROG_AWK
 AC_PROG_SED
-AC_PROG_CC_C99
+m4_version_prereq([2.70], [AC_PROG_CC], [AC_PROG_CC_C99])
 AC_PROG_LN_S
 AC_CHECK_TOOL([LD], [ld])
 AC_CHECK_TOOL([READELF], [readelf])
-- 
2.31.1


From mark@klomp.org  Sat Jan 28 23:07:56 2023
From: mark@klomp.org (Mark Wielaard)
Date: Sun, 29 Jan 2023 00:07:56 +0100
Subject: [PATCH] scripts/find-debuginfo.in: Add -q|--quiet
In-Reply-To: <92604e62-0121-dd93-a7f6-a86bd01dc0dd@redhat.com>
References: <20230126210857.3867040-1-prarit@redhat.com>
 <16f282cf1aef62db202c3cc8902b406dae08e9bc.camel@klomp.org>
 <92604e62-0121-dd93-a7f6-a86bd01dc0dd@redhat.com>
Message-ID: <20230128230756.GA11361@gnu.wildebeest.org>

Hi Prarit,

On Sat, Jan 28, 2023 at 08:24:06AM -0500, Prarit Bhargava wrote:
> On 1/27/23 12:38, Mark Wielaard wrote:
> >Looks perfect. Applied as is. Also backported to Fedora rawhide package
> >debugedit-5.0-7.fc38 so you can test it out there.
> >
> 
> Thanks.  LGTM.  Is there any chance you could also create packages
> for F37 and F36?
> 
> https://src.fedoraproject.org/rpms/debugedit
> 
> I'd like to add --quiet to the kernel.spec but cannot do so until
> the fix reaches all supported fedora releases.

Backported to f36 and f37

  https://bodhi.fedoraproject.org/updates/FEDORA-2023-9ed6123537
  https://bodhi.fedoraproject.org/updates/FEDORA-2023-afb47cff16

It will take a couple of days/weeks for it lands, it needs to spend
some time in testing.

Cheers,

Mark


From mark@klomp.org  Mon Jan 30 19:58:16 2023
From: mark@klomp.org (Mark Wielaard)
Date: Mon, 30 Jan 2023 20:58:16 +0100
Subject: Sourceware network outage, Tuesday 2023-01-31
Message-ID: <20230130195816.GN11361@gnu.wildebeest.org>

We've received word from our data centre hosts that they will have a
network infrastructure outage tomorrow, Tuesday 2023-01-31, between
8am and 12am EST (UTC-5). We may follow that up with a server
firmware-related update/boot.

This impacts sourceware.org, builder.sourceware.org,
patchwork.sourceware.org, inbox.sourceware.org, valgrind.org,
elfutils.org, cygwin.com and gcc.gnu.org, which all may be unreachable
for a couple of hours.

Note that there are read-only mirrors of the git repositories at
https://sr.ht/~sourceware/ if you need access during the outage.

Please feel free to hang out at irc.libera.chat #overseers to follow
the current status.



