[PATCH] Fail if dwz fails.

[Mark Wielaard]

Hi Martin,

On Thu, 2021-05-13 at 10:01 +0200, Martin Liška wrote:
> PING^1

Sorry I missed this earlier.

> On 4/22/21 1:11 PM, Martin Liška wrote:
> > Right now, dwz return code is 0 or a small integer value (<= 3)
> > for situations like:
> > 
> > - dwz: Too few files for multifile optimization
> > - dwz: Multi-file optimization not allowed for different pointer sizes or endianity
> > 
> > These are not fatal errors and the script should continue. On the other
> > hand abort or segfault error values should cause failure of the script.
> > 
> > Let's reserve values 1-16 for a recoverable dwz exit codes.

With "recoverable" you mean that dwz did do compression, but could not
deliver optimal compression?

It would be good to have an ack from the dwz developers that 1 to 16
are "recoverable" errors (I added dwz@sourceware.org to CC).

Would it be possible to tweak the find-debuginfo.sh script to avoid
them? e.g. Could we see how many arguments we have so that we only use
-m when there are 1+ debug files? And/Or detect debug files using
different endianess and ptr sizes so they are processed in different
batches?

Ideally an error code from dwz means something went terribly wrong and
we abort find-debuginfo.sh. IMHO.

Cheers,

Mark