[Bug debugedit/27890] tests using CFLAGS/LDFLAGS causes testsuite failures

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27890

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |mark at klomp dot org
             Status|NEW                         |ASSIGNED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
To fix this I intend to push something like the following:

diff --git a/tests/atlocal.in b/tests/atlocal.in
index a45edac..0eec351 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -3,10 +3,12 @@

 PATH=@abs_builddir@:@abs_top_builddir@:$top_srcdir:$srcdir:$PATH

+# We do use the CC and LD found by configure, but explicitly keep
+# CFLAGS and LDFLAGS empty because the tests use specific flags.
 CC="@CC@"
-CFLAGS="@CFLAGS@"
+CFLAGS=""
 LD="@LD@"
-LDFLAGS="@LDFLAGS@"
+LDFLAGS=""

 GDWARF_5_FLAG=@GDWARF_5_FLAG@
 GZ_NONE_FLAG=@GZ_NONE_FLAG@

It would still allow using different compilers/linkers, but not to override the
CFLAGS/LDFLAGS for the tests themselves (unless you edit atlocal by hand.

Does the above seem reasonable?

-- 
You are receiving this mail because:
You are on the CC list for the bug.