unzip failure with files that contain colons

[Adam Dinwoodie]

On Fri, Jun 17, 2022 at 12:29:39AM +0900, Takashi Yano wrote:
> On Thu, 16 Jun 2022 06:22:38 +0200
> Thomas Wolff wrote:
> > Am 15.06.2022 um 20:30 schrieb Adam Dinwoodie:
> > > Cygwin generally handles filenames with colons just fine, by mapping the
> > > character to some higher Unicode character and remapping on the fly.
> > > However Cygwin's `unzip` appears to have a bug: when unzipping an
> > > archive that contains a filename with a colon, it replaces the colon
> > > with an underscore.
> > >
> > > cygcheck.out and simple test script attached; expected behaviour from
> > > running `bash unzip-bug.sh` is that you get an empty file called `a:b`,
> > > but on Cygwin you instead get an empty file called `a_b`.
> > It's an explicit #ifdef __CYGWIN__ in upstream unzip, file unix/unix.c, 
> > which transforms a bunch of characters.
> > If I uncomment most of them (except \), all unpack fine:
> > x0:z  x1<z  x2>z  x3|z  x4"z  x5?z  x6*z
> 
> I have taken over the maintenance of unzip package, and
> fix the problem in the updated unzip-6.0-18.
> https://cygwin.com/pipermail/cygwin/2022-June/251653.html
> 
> Please try.

Confirmed fixed.  Thank you for adopting this and the quick turnaround!

Adam