cygwin on git master fails to start.
Takashi Yano
takashi.yano@nifty.ne.jp
Thu Jul 28 14:21:40 GMT 2022
Hi Corinna,
After the following commit, cygwin fails to start in my
environment.
commit e46f15c2d168abea34b4d880b4eba38d750c7066
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Thu Jul 14 20:06:09 2022 +0200
Cygwin: hookapi: drop handling i386 targets
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
diff --git a/winsup/cygwin/hookapi.cc b/winsup/cygwin/hookapi.cc
index fbf13ce90..3ce1e0fb2 100644
--- a/winsup/cygwin/hookapi.cc
+++ b/winsup/cygwin/hookapi.cc
@@ -39,12 +39,10 @@ PEHeaderFromHModule (HMODULE hModule, bool &is_64bit)
{
pNTHeader = PIMAGE_NT_HEADERS (PBYTE (hModule)
+ PIMAGE_DOS_HEADER (hModule) ->e_lfanew);
- if (pNTHeader->Signature != IMAGE_NT_SIGNATURE)
+ if (pNTHeader->Signature == IMAGE_NT_SIGNATURE)
pNTHeader = NULL;
else if (pNTHeader->FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64)
is_64bit = true;
- else if (pNTHeader->FileHeader.Machine == IMAGE_FILE_MACHINE_I386)
- is_64bit = false;
else
pNTHeader = NULL;
}
Is this the right thing?
- if (pNTHeader->Signature != IMAGE_NT_SIGNATURE)
+ if (pNTHeader->Signature == IMAGE_NT_SIGNATURE)
pNTHeader = NULL;
--
Takashi Yano <takashi.yano@nifty.ne.jp>
More information about the Cygwin
mailing list