Patch request to qt 5.9.4 (Re: [ANNOUNCEMENT] Qt 5.9.4)

[Tatsuro MATSUOKA]

----- Original Message -----

> From: Yaakov Selkowitz <yselkowitz
> To: cygwin
> Cc: 
> Date: 2019/3/11, Mon 09:53
> Subject: Re: Patch request to qt 5.9.4 (Re: [ANNOUNCEMENT] Qt 5.9.4)
> 
> On Mon, 2019-03-11 at 09:28 +0900, Tatsuro MATSUOKA wrote:
>>  > On Mon, 2019-03-04 at 07:43 +0900, Tatsuro MATSUOKA wrote:
>>  > >  I ask alpply a patch the below which enables to use qt terminal 
> on gnuplot 
>>  > for Cygwin.
>>  > >  (cygQt5Network-5.dll is affected.)
>>  > > 
>>  > >  --- 
> a/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
>>  > >  +++ 
> b/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
>>  > >  @@ -239,7 +239,7 @@ void QLocalSocket::connectToServer(OpenM
>>  > >      }
>>  > >      // create the socket
>>  > >  -    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, 
> SOCK_STREAM, 0, O_NONBLOCK))) {
>>  > >  +    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, 
> SOCK_STREAM, 0))) {
>>  > >          d->errorOccurred(UnsupportedSocketOperationError, 
> QLatin1String("QLocalSocket::connectToServer"));
>>  > >          return;
>>  > > 
>>  > 
>>  > It seems we keep going in circles on this point.  If there is a bug in
>>  > O_NONBLOCK, then please either narrow it down to an STC, or provide a
>>  > patch to Cygwin.
>> 
>>  Very basic question. What is STC?
>>  I googled but I cannot find what is it.
> 
> https://cygwin.com/acronyms/#STC 


Sorry I cannot make STC due to lack of knowledge of QT.
In stead, I explain what gnuplot do.

On gnuplot for qt, 
plot is done by child process named gnuplot_qt. 

When gnuplot connect with gnuplot with 
  qt->socket.connectToServer(server);


without the above patch ()
qt_safe_socket(PF_UNIX, SOCK_STREAM, 0, O_NONBLOCK)))
gnuplot cannot connect with gnuplot_qt.

with the above patch ()
qt_safe_socket(PF_UNIX, SOCK_STREAM, 0))
gnuplot can connect with gnuplot_qt.

Perhaps qt with O_NONBLOCK is some wrong with process connection.



Tatsuro 


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple