OpenBLAS patch for Cygwin
Corinna Vinschen
corinna-cygwin@cygwin.com
Tue Feb 6 14:24:00 GMT 2018
On Feb 6 15:15, Marco Atzeri wrote:
> On 06/02/2018 13:10, Erik Bray wrote:
> > Hello,
> >
> > Users/maintainers of OpenBLAS on Cygwin may be interested in this
> > patch to improve support for fork():
> > https://github.com/xianyi/OpenBLAS/pull/1450
> >
> > Assuming this looks good (feedback welcome) it might be nice to have
> > this patch included in the next release of the official OpenBLAS
> > package for Cygwin since its incompatibility with fork() has caused
> > problems in the past [1].
> >
> >
> > Thanks,
> > E
> >
> > [1] https://trac.sagemath.org/ticket/22822
> >
>
>
> Noted.
> Do you have a test case to show the failure with current build ?
>
> Any reason to use OS_CYGWIN_NT and not __CYGWIN__ in the patch ?
Also, it should really use pthread functions and drop the notion that
Cygwin is a Windows target. Assuming you're running fork from another
thread than the main thread, does it still work with native Windows
threads?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20180206/3db9862b/attachment.sig>
More information about the Cygwin
mailing list