ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)

Shaddy Baddah lithium-cygwin@shaddybaddah.name
Thu Jan 19 11:26:00 GMT 2017


Hi,

On 19/01/17 21:38, Corinna Vinschen wrote:
> On Jan 18 14:34, Shaddy Baddah wrote:
...

>> And I'm sure the problem is that this well-intended change to the script
>> fails on the assumption that LOGONSERVER is always populated. It isn't
>> for me on Vista.
>>
>> cygwin-service-installation-helper.sh:2884:      # This test succeeds on
>> domain member machines only, not on DCs.
>> cygwin-service-installation-helper.sh:2885:      if [
>> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
>> cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}" !=
>> "\\\\MicrosoftAccount" ]
>> cygwin-service-installation-helper.sh:2887:      then
>> cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDOMAIN
>> cygwin-service-installation-helper.sh:2889:
>> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
>> cygwin-service-installation-helper.sh:2890:      fi
>> cygwin-service-installation-helper.sh:2891:    fi
>>
>> I fixed this by modifying the test to check LOGONSERVER is not empty:
>>
>> if [ -n "${LOGONSERVER}" -a "\\\\...
>>
>> Can this be fixed in the next release?
>
> Sure, please provide a patch, I'll check it in and release a new csih
> soonish.

I would, but there's a couple of hitches. Without understanding the
syntax (and I should bring up the bash man page here, I will do after
this), I can't be sure that the following test:

"\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"

wasn't designed to handled an empty LOGONSERVER variable. Though it
looks to me that it is a binary test (i.e. handling both variables being
empty).

And secondly, I am not sure that chucking in the -n "${LOGONSERVER}"
test is safe in a Vista domain environment. From the comment about the
line, it seems like the original author of those lines, whomever that
may be, might have a strong understanding to make the modification.

But that's not constructive on my part. I'll come up with a patch in the
next 24 hours (it is late where I am now).

-- 
Regards,
Shaddy


>
>
> Thanks,
> Corinna
>


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple



More information about the Cygwin mailing list