Group Permissions on root folders problem (Windows 10 TP build 10061)
Corinna Vinschen
corinna-cygwin@cygwin.com
Thu Sep 10 17:49:00 GMT 2015
On Sep 10 11:36, Eric Blake wrote:
> On 09/10/2015 11:31 AM, Corinna Vinschen wrote:
>
> >>>> - if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" ]
> >>>> + if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> >>>> + -a "${LOGONSERVER}" != "\\\\MicrosoftAccount" ]
> >>>> then
> >>>> # Lowercase of USERDOMAIN
> >>>> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> >>>
> >>> Thanks a lot, much appreciated. Patch applied.
> >>
> >> [ ... -a ... ] is not portable; there are some inherently ambiguous
> >> situations that it cannot handle. POSIX recommends that you spell it [
> >> ... ] && [ ... ] instead.
> >
> > Does this matter in this very situation? This is always running under
> > bash, btw. Bash's a requirement for the csih helper script.
>
> Because you are at least using bash, you will get consistent behavior;
> and because both ... are 3-argument tests, it is unlikely that one of
> the tests can be confused with other operators like '(' or ')'. So, I
> guess it's okay to leave it alone here. But even with bash, the use of
> -a can cause problems when testing user-supplied variables that might
> happen to expand to text that looks like potential operators.
Feel free to change that in the csih repo. Csih is under git now,
see https://sourceware.org/git/?p=cygwin-csih.git. You're in the
cygwin-apps group, so you have checkin rights.
If I didn't mention that before, I'm glad for any help since I only took
over because Chuck disappeared.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20150910/448ad755/attachment.sig>
More information about the Cygwin
mailing list