setfacl(2.4.0): colon missing after x (opts string)?

[Corinna Vinschen]

On Dec 19 14:03, Houder wrote:
> Hi Corinna,
> 
> setfacl(2.4.0) does not accept -x <acl_entry> (-d <acl_entry> is accepted).
> 
> Looking at the source of setfacl.c, I believe a colon is missing after x in
> the opts string (const char *opts).
> 
> Regards,
> Henri
> 
> newlib-cygwin-2.4.0/gnewlib-cygwin-2.4.0/newlib-cygwin/winsup/utils/setfacl.c
> 
> shows:
> 
> struct option longopts[] = {
>   {"remove-all", no_argument, NULL, 'b'},
>   {"delete", required_argument, NULL, 'x'},
>   {"file", required_argument, NULL, 'f'},
>   {"remove-default", no_argument, NULL, 'k'},
>   {"modify", required_argument, NULL, 'm'},
>   {"no-mask", required_argument, NULL, 'n'},
>   {"mask", required_argument, NULL, '\n'},
>   {"replace", no_argument, NULL, 'r'},
>   {"substitute", required_argument, NULL, 's'},
>   {"help", no_argument, NULL, 'h'},
>   {"version", no_argument, NULL, 'V'},
>   {0, no_argument, NULL, 0}
> };
> const char *opts = "bd:f:hkm:nrs:Vx"; <==== colon missing after x ?????

Indeed,  Thanks for catching.  Patch applied.  I'm going to upload
a 0-13 test relese with this patch in a bit.


Thanks again,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20151219/1475cf41/attachment.sig>