[PATCH] Check for existence of the path before processing '..'

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Jun 11 17:30:00 GMT 2013

On Jun 11 11:17, Christopher Faylor wrote:
> On Tue, Jun 11, 2013 at 05:04:46PM +0200, Corinna Vinschen wrote:
> >On Jun 11 10:20, Christopher Faylor wrote:
> >> You introduce a check_parent flag which is set every time a non-slash
> >> character is found.  That doesn't seem right.  It seems like it should
> >> be set whenever you see a slash.
> >
> >Indeed.  I moved setting check_parent before the while expression in
> >the else branch instead and it still works.
> I'll bet you wouldn't see much of a hit if you just got rid of the
> check_parent flag entirely.

Actually, to my own surprise, it does.  I removed the flag and the code
takes 3 seconds longer on average to build coreutils:  136.2 vs. 133.4
vs. 132.3.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

More information about the Cygwin mailing list