libtool quoting error

Andreas Schiffler aschiffler@ferzkopp.net
Sun Aug 19 18:25:00 GMT 2012


The libtool distributed with cygwin has a bug that prevents use in paths 
containing spaces.
This was encountered when trying to build SDL2 on Windows (see 
http://bugzilla.libsdl.org/show_bug.cgi?id=1575 for details or repro).

# Which release of libtool.m4 was used?
macro_version=2.2.6
macro_revision=1.3012

The fix is simple: add additional quoting.

$ diff libtool libtool-fixed
2797c2797
<       exec_cmd='$SHELL $progpath $preserve_args --finish$current_libdirs'
---
 >       exec_cmd='$SHELL "$progpath" $preserve_args 
--finish$current_libdirs'
8321c8321
<       if test "X$ECHO" = "X$SHELL $progpath --fallback-echo"; then
---
 >       if test "X$ECHO" = "X$SHELL \"$progpath\" --fallback-echo"; then
8323,8324c8323,8324
<       [\\/]* | [A-Za-z]:[\\/]*) qecho="$SHELL $progpath --fallback-echo";;
<       *) qecho="$SHELL `pwd`/$progpath --fallback-echo";;
---
 >       [\\/]* | [A-Za-z]:[\\/]*) qecho="$SHELL \"$progpath\" 
--fallback-echo";;
 >       *) qecho="$SHELL `pwd`/\"$progpath\" --fallback-echo";;
8559c8559
<       relink_command="(cd `pwd`; $SHELL $progpath $preserve_args 
--mode=relink $libtool_args @inst_prefix_dir@)"
---
 >       relink_command="(cd `pwd`; $SHELL \"$progpath\" $preserve_args 
--mode=relink $libtool_args @inst_prefix_dir@)"

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple



More information about the Cygwin mailing list