Attn: cygport maintainer [was: Re: Libtool 2.2.2]

[Yaakov (Cygwin Ports)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Charles Wilson wrote:
| Yaakov (Cygwin Ports) wrote:
|> AU_DEFUN([AC_PROG_LIBTOOL],
|> [LT_INIT
|> LT_OUTPUT
|> AC_DIAGNOSE([obsolete],
|> [$0: Remove this warning and the call to LT_OUTPUT if you do not need
|> libtool to exist before AC_OUTPUT.])
|> ])
|>
|> AU_ALIAS([AM_PROG_LIBTOOL], [AC_PROG_LIBTOOL])
|
| That looks OK to me. I'll include something like this in the next
| version of libtool2.2 (or "libtool" test: 2.2).

One more patch will be required, namely, to define OBJDUMP where
necessary.  I've rolled these two patches together, as attached.

Explanation:

The AC_LIBTOOL_WIN32_DLL macro was supposed to be used in packages which
built on Win32 platforms, in order to create DLLs.  This macro tested
for as, dlltool, and objdump.  The latter is used in the file_magic test
to determine if a .a is a static or import library.

In 1.5 libtool worked anyway without it, because among other variables,
OBJDUMP was given a "sane default" near the beginning of libtool.m4 and
was always exported, and AS and DLLTOOL weren't needed.

But in 2.2, the "sane defaults" have been minimized, and OBJDUMP is no
longer defined by default, so without the win32-dll arg to LT_INIT (or
the AC_LIBTOOL_WIN32_DLL compat macro), libtool refuses to link shared
libs against non-libtoolized shared libs, because the file_magic test on
the implib fails due to an undefined OBJDUMP variable.  Assuring that
OBJDUMP is defined is therefore necessary for compatibility with
previous behaviour.

Not only that, but this may fix another possible bug on Linux ELF
systems, as there is a test on that platform (line 2461 after the patch)
which uses OBJDUMP, which I don't see where it would have been defined.



Yaakov

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIAeHppiWmPGlmQSMRCLo1AKDx1ENwmwMhmKvL12avJ1RuVJfBHACg2g69
NKjvebLP38bbNdqP/cis8GI=
=Z4Tf
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libtool-cygwin.diff
URL: <http://cygwin.com/pipermail/cygwin/attachments/20080413/b39ffc1e/attachment.ksh>
-------------- next part --------------
--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/